github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 13:36:39 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1923] [MERGED] [PS-672] Accessibility - File/Text controls unintuitive, "Text" accessible name incorrect #3221

New Issue
Closed
opened 2025-11-26 23:29:53 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:53 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1923
Author: @andrebispo5
Created: 5/24/2022
Status: ✅ Merged
Merged: 5/25/2022
Merged by: @andrebispo5

Base: master ← Head: bug/ps-672-send-voiceover

📝 Commits (5)

  • 12647ea PS-672: Accessibility - File/Text controls unintuitive, "Text" accessible name incorrect
  • 43f00f0 PS-672: refactor code with pr suggestions
  • a6ff137 PS-672: removed unnecessary code
  • f89694b PS-672: change text from "click" to "tap"
  • 8ee0286 PS-672: removed comma

📊 Changes

4 files changed (+51 additions, -0 deletions)

View changed files

📝 src/App/Pages/Send/SendAddEditPage.xaml (+2 -0)
📝 src/App/Pages/Send/SendAddEditPageViewModel.cs (+4 -0)
📝 src/App/Resources/AppResources.Designer.cs (+30 -0)
📝 src/App/Resources/AppResources.resx (+15 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Change the segmented button (File/Text) in Sends tab, to have a better voice feedback to the user using TalkBack or VoiceOver. Added a missing "Text" resource and dynamic voice over based on button state.

Code changes

  • src/App/Pages/Send/SendAddEditPageViewModel.cs: Label properties for button states
  • src/App/Pages/Send/SendAddEditPage.xaml.cs: Accessibility help text change on button click and screen init.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1923 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 5/24/2022 **Status:** ✅ Merged **Merged:** 5/25/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bug/ps-672-send-voiceover` --- ### 📝 Commits (5) - [`12647ea`](https://github.com/bitwarden/android/commit/12647ea6cdea3537bca30a34d7f1b32101dd031e) PS-672: Accessibility - File/Text controls unintuitive, "Text" accessible name incorrect - [`43f00f0`](https://github.com/bitwarden/android/commit/43f00f0dad91226194f860e793240913ddf0a983) PS-672: refactor code with pr suggestions - [`a6ff137`](https://github.com/bitwarden/android/commit/a6ff1378b2a05a5528b9a47d92cb0e8cd9591d3e) PS-672: removed unnecessary code - [`f89694b`](https://github.com/bitwarden/android/commit/f89694b8b69ce638f731ab7ed2573ceb9ee655b7) PS-672: change text from "click" to "tap" - [`8ee0286`](https://github.com/bitwarden/android/commit/8ee02868abdddc9f90ef70256c97d05e9a1cd351) PS-672: removed comma ### 📊 Changes **4 files changed** (+51 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Send/SendAddEditPage.xaml` (+2 -0) 📝 `src/App/Pages/Send/SendAddEditPageViewModel.cs` (+4 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+30 -0) 📝 `src/App/Resources/AppResources.resx` (+15 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Change the segmented button (File/Text) in Sends tab, to have a better voice feedback to the user using TalkBack or VoiceOver. Added a missing "Text" resource and dynamic voice over based on button state. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/App/Pages/Send/SendAddEditPageViewModel.cs:** Label properties for button states * **src/App/Pages/Send/SendAddEditPage.xaml.cs:** Accessibility help text change on button click and screen init. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:53 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3221
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?