Android: Auto fill dialog only shows entries with standard match detection #322

@kspearrin commented on GitHub (Jan 4, 2019):

Not enough information. Please explain the issue further.

@kspearrin commented on GitHub (Jan 4, 2019): Not enough information. Please explain the issue further.

GiteaMirror commented

@quthla commented on GitHub (Jan 4, 2019):

Example

Url xyz.com/test

Add 2 entries. One with regular match detection, one with url starts with match detection. Navigate to xyz.com/test, it will only show the first entry

I'm using Chrome on Android in case that matters

@quthla commented on GitHub (Jan 4, 2019): Example Url xyz.com/test Add 2 entries. One with regular match detection, one with url starts with match detection. Navigate to xyz.com/test, it will only show the first entry I'm using Chrome on Android in case that matters

GiteaMirror commented

@kspearrin commented on GitHub (Jan 5, 2019):

Which autofill service are you using? Accessibility or Oreo/Pie autofill?

@kspearrin commented on GitHub (Jan 5, 2019): Which autofill service are you using? Accessibility or Oreo/Pie autofill?

GiteaMirror commented

@quthla commented on GitHub (Jan 6, 2019):

Pie autofill

@quthla commented on GitHub (Jan 6, 2019): Pie autofill

GiteaMirror commented

@djboge commented on GitHub (Jun 13, 2019):

I'm pretty sure I have this issue as well.

I have a bunch of logins for various subdomains of ".state.xx.us" i.e. mail or apps or payroll, etc. I have them all set to "begins with" match detection, because they all have separate logins.

When I visit any of them on Android Chrome, it says "no logins" if I tap the little box that comes up next to the login fields. If I tap out of that and go to the notification, it will show the login there.

@djboge commented on GitHub (Jun 13, 2019): I'm pretty sure I have this issue as well. I have a bunch of logins for various subdomains of ".state.xx.us" i.e. mail or apps or payroll, etc. I have them all set to "begins with" match detection, because they all have separate logins. When I visit any of them on Android Chrome, it says "no logins" if I tap the little box that comes up next to the login fields. If I tap out of that and go to the notification, it will show the login there.

GiteaMirror commented

@cognition9144 commented on GitHub (Jul 9, 2019):

Setting match detection to Host also still has the same effect as Base Domain.

E.g. A Login entry with URI www.example.com matches website abc.example.com

@cognition9144 commented on GitHub (Jul 9, 2019): Setting match detection to Host also still has the same effect as Base Domain. E.g. A Login entry with URI `www.example.com` matches website `abc.example.com`

GiteaMirror commented

@Loakii commented on GitHub (Jul 9, 2019):

I have the same issue with Pie autofill.

Bitwarden version: 2.1.0 (8 Jul 2019) (beta)
Google Chrome version: 75.0.3770.101

For example: I have a password stored for https://example.com:8443 with start with detection. Bitwarden would fail to give an option to autofill the information as shown below. Tapping "Go to my vault" shows the message "There are no items in your vault for ***".

If I set the detection to base domain the autofill option works as shown below.

@Loakii commented on GitHub (Jul 9, 2019): I have the same issue with Pie autofill. Bitwarden version: 2.1.0 (8 Jul 2019) (beta) Google Chrome version: 75.0.3770.101 For example: I have a password stored for https://example.com:8443 with **start with** detection. Bitwarden would fail to give an option to autofill the information as shown below. Tapping "Go to my vault" shows the message "There are no items in your vault for ***". ![2019-07-09 16 23 33](https://user-images.githubusercontent.com/47106497/60896539-d119be80-a266-11e9-90a2-377d3f064bc8.jpg) If I set the detection to **base domain** the autofill option works as shown below. ![2019-07-09 16 24 06](https://user-images.githubusercontent.com/47106497/60896617-f1497d80-a266-11e9-8342-bfc1fb9dd719.jpg)

GiteaMirror commented

@kspearrin commented on GitHub (Jul 11, 2019):

The reason this happens is that the autofill APIs were only returning the "WebDomain" property of the page, which is just "domain.com" and does not include the scheme (http vs https). Therefore, when no scheme is present, we assume http://. If your "starts with" match detection is on a URI such as https://domain (s), then we do not have a match.

However, in Android Pie (API 28), they added an additional property to get the scheme as well (called WebScheme). We can now accurately detect the scheme of the page. I have added a fix. You can test the latest dev build with this fix here if you like: https://ci.appveyor.com/project/bitwarden/mobile/build/job/4ai23fw0a3frhsrm/artifacts

Devices on < Pie (28) will still default to http:// scheme and match detection against https:// stored URIs will not work.

@kspearrin commented on GitHub (Jul 11, 2019): The reason this happens is that the autofill APIs were only returning the "WebDomain" property of the page, which is just "domain.com" and does not include the scheme (http vs https). Therefore, when no scheme is present, we assume `http://`. If your "starts with" match detection is on a URI such as http**s**://domain (s), then we do not have a match. However, in Android Pie (API 28), they added an additional property to get the scheme as well (called WebScheme). We can now accurately detect the scheme of the page. I have added a fix. You can test the latest dev build with this fix here if you like: https://ci.appveyor.com/project/bitwarden/mobile/build/job/4ai23fw0a3frhsrm/artifacts Devices on < Pie (28) will still default to `http://` scheme and match detection against https:// stored URIs will not work.

GiteaMirror commented

@kspearrin commented on GitHub (Jul 11, 2019):

Fix is also going out to play store beta, build 2019.

@kspearrin commented on GitHub (Jul 11, 2019): Fix is also going out to play store beta, build 2019.

GiteaMirror commented

@Loakii commented on GitHub (Jul 11, 2019):

I'm either doing something wrong or it's still not working on the dev build.

URI is saved with https://

Current version: 2.1.0 (2020)

@Loakii commented on GitHub (Jul 11, 2019): I'm either doing something wrong or it's still not working on the dev build. URI is saved with https:// Current version: 2.1.0 (2020)

GiteaMirror commented

@kspearrin commented on GitHub (Jul 11, 2019):

@Loakii Are you using Android P? I was able to reproduce the issue before, but seems to work in my tests now.

URI: starts with "https://gith"
Visit github sign in page
Login is properly shown

@kspearrin commented on GitHub (Jul 11, 2019): @Loakii Are you using Android P? I was able to reproduce the issue before, but seems to work in my tests now. 1. URI: starts with "https://gith" 2. Visit github sign in page 3. Login is properly shown

GiteaMirror commented

@Loakii commented on GitHub (Jul 11, 2019):

@kspearrin Ah yes! I guess it's the ports at the end that screw it up in my case.
I assume there's no way of making that work for now?

I have one domain with multiple webapps running on different ports and they all use different credentials.

@Loakii commented on GitHub (Jul 11, 2019): @kspearrin Ah yes! I guess it's the ports at the end that screw it up in my case. I assume there's no way of making that work for now? I have one domain with multiple webapps running on different ports and they all use different credentials.

GiteaMirror commented