github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 06:59:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1921] [MERGED] [PS-90] App keeps asking for 2FA even though I've checked the "remember me" checkbox. #3219

New Issue
Closed
opened 2025-11-26 23:29:52 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:52 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1921
Author: @andrebispo5
Created: 5/23/2022
Status: ✅ Merged
Merged: 5/24/2022
Merged by: @andrebispo5

Base: master ← Head: bug/ps-90-2fa-remember-me

📝 Commits (1)

  • 8511ffa PS-90: App keeps asking for 2FA even though I've checked the "remember me" checkbox

📊 Changes

2 files changed (+1 additions, -4 deletions)

View changed files

📝 src/Core/Services/AuthService.cs (+1 -0)
📝 src/Core/Services/StateService.cs (+0 -4)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

App keeps asking for 2FA, even if "remember me" was previously selected.

Code changes

  • AuthService.cs: Previous 2FA code gets cleared if there is an auth error regarding 2FA.
  • StateService.cs: Removed code that was deleting user 2FA token. Not having this token was causing 2FA login after user logout.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1921 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 5/23/2022 **Status:** ✅ Merged **Merged:** 5/24/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bug/ps-90-2fa-remember-me` --- ### 📝 Commits (1) - [`8511ffa`](https://github.com/bitwarden/android/commit/8511ffa91fcb79c278fe83f9bae9d45501c0db1c) PS-90: App keeps asking for 2FA even though I've checked the "remember me" checkbox ### 📊 Changes **2 files changed** (+1 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/AuthService.cs` (+1 -0) 📝 `src/Core/Services/StateService.cs` (+0 -4) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective App keeps asking for 2FA, even if "remember me" was previously selected. ## Code changes * **AuthService.cs:** Previous 2FA code gets cleared if there is an auth error regarding 2FA. * **StateService.cs:** Removed code that was deleting user 2FA token. Not having this token was causing 2FA login after user logout. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:52 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3219
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?