github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5869] [MERGED] [PM-15051] Add CredentialExchangeRegistry #32117

New Issue
Closed
opened 2026-04-18 15:33:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 15:33:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5869
Author: @SaintPatrck
Created: 9/11/2025
Status: ✅ Merged
Merged: 9/15/2025
Merged by: @SaintPatrck

Base: main ← Head: cxf/cx-registry

📝 Commits (4)

  • 3ab88b2 [PM-15051] Add CredentialExchangeRegistry
  • 468fabc Refactor CredentialExchangeRegistry
  • 1920275 Update CXF registration to use drawable resource
  • 78c38cd Fix RegistrationRequest icon resource annotation

📊 Changes

4 files changed (+158 additions, -0 deletions)

View changed files

➕ cxf/src/main/kotlin/com/bitwarden/cxf/registry/CredentialExchangeRegistry.kt (+32 -0)
➕ cxf/src/main/kotlin/com/bitwarden/cxf/registry/CredentialExchangeRegistryImpl.kt (+61 -0)
➕ cxf/src/main/kotlin/com/bitwarden/cxf/registry/dsl/CredentialExchangeRegistryBuilder.kt (+47 -0)
➕ cxf/src/main/kotlin/com/bitwarden/cxf/registry/model/RegistrationRequest.kt (+18 -0)

📄 Description

🎟️ Tracking

PM-15051

📔 Objective

This change introduces the CredentialExchangeRegistry interface and its implementation, CredentialExchangeRegistryImpl. This registry allows an application to register itself as a credential provider, enabling users to import credentials from it to other credential managers.

The following key components are added:

  • CredentialExchangeRegistry: Interface defining methods to register and unregister as a credential export source.
  • CredentialExchangeRegistryImpl: Default implementation of CredentialExchangeRegistry using ProviderEventsManager.
  • RegistrationRequest: Data class representing the information needed to register as a credential provider, including app name, supported credential types, and an icon.
  • credentialExchangeRegistry DSL: A DSL function and builder (CredentialExchangeRegistryBuilder) for easy construction of CredentialExchangeRegistry instances.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5869 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 9/11/2025 **Status:** ✅ Merged **Merged:** 9/15/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `cxf/cx-registry` --- ### 📝 Commits (4) - [`3ab88b2`](https://github.com/bitwarden/android/commit/3ab88b2dbe922598c08992d00a7e882e27cbb5fc) [PM-15051] Add CredentialExchangeRegistry - [`468fabc`](https://github.com/bitwarden/android/commit/468fabce0e8fd07de9905894f1b44f1993db9d6c) Refactor CredentialExchangeRegistry - [`1920275`](https://github.com/bitwarden/android/commit/1920275901f1c7a18231244f37052ea4fc24f3a6) Update CXF registration to use drawable resource - [`78c38cd`](https://github.com/bitwarden/android/commit/78c38cdfc2a98da19c3a2180aa5b94fd204a61ab) Fix `RegistrationRequest` icon resource annotation ### 📊 Changes **4 files changed** (+158 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `cxf/src/main/kotlin/com/bitwarden/cxf/registry/CredentialExchangeRegistry.kt` (+32 -0) ➕ `cxf/src/main/kotlin/com/bitwarden/cxf/registry/CredentialExchangeRegistryImpl.kt` (+61 -0) ➕ `cxf/src/main/kotlin/com/bitwarden/cxf/registry/dsl/CredentialExchangeRegistryBuilder.kt` (+47 -0) ➕ `cxf/src/main/kotlin/com/bitwarden/cxf/registry/model/RegistrationRequest.kt` (+18 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-15051 ## 📔 Objective This change introduces the `CredentialExchangeRegistry` interface and its implementation, `CredentialExchangeRegistryImpl`. This registry allows an application to register itself as a credential provider, enabling users to import credentials from it to other credential managers. The following key components are added: - `CredentialExchangeRegistry`: Interface defining methods to register and unregister as a credential export source. - `CredentialExchangeRegistryImpl`: Default implementation of `CredentialExchangeRegistry` using `ProviderEventsManager`. - `RegistrationRequest`: Data class representing the information needed to register as a credential provider, including app name, supported credential types, and an icon. - `credentialExchangeRegistry` DSL: A DSL function and builder (`CredentialExchangeRegistryBuilder`) for easy construction of `CredentialExchangeRegistry` instances. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 15:33:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#32117
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?