github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 13:36:39 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1905] [MERGED] PS-518 - Add setting to block AppCenter / Analytics - Mobile #3211

New Issue
Closed
opened 2025-11-26 23:29:44 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:44 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1905
Author: @andrebispo5
Created: 5/12/2022
Status: ✅ Merged
Merged: 5/18/2022
Merged by: @andrebispo5

Base: master ← Head: feature/appcenter-toggle

📝 Commits (7)

  • 16e7921 PS-518 - Add setting to block AppCenter / Analytics - Mobile
  • cf8cbff PS-518 Add setting to block AppCenter / Analytics - Mobile
  • 23aebde PS-518 Add setting to block AppCenter / Analytics - Mobile
  • 2ae1167 PS-518 Add setting to block AppCenter / Analytics - Mobile
  • 42b0419 PS-518 Add setting to block AppCenter / Analytics - Mobile
  • 71dd79f PS-518 Add setting to block AppCenter / Analytics - Mobile
  • 919dd5a PS-518

📊 Changes

22 files changed (+172 additions, -177 deletions)

View changed files

📝 .github/workflows/build.yml (+0 -12)
📝 src/Android/Android.csproj (+0 -1)
📝 src/Android/MainActivity.cs (+2 -4)
📝 src/Android/Services/BiometricService.cs (+4 -9)
➖ src/Android/Utilities/AppCenterHelper.cs (+0 -58)
📝 src/App/App.csproj (+0 -1)
📝 src/App/Pages/Settings/SettingsPage/SettingsPage.xaml.cs (+4 -0)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+37 -3)
📝 src/App/Resources/AppResources.Designer.cs (+12 -0)
📝 src/App/Resources/AppResources.resx (+6 -0)
📝 src/Core/Abstractions/ILogger.cs (+18 -0)
📝 src/Core/Services/Logging/DebugLogger.cs (+7 -0)
📝 src/Core/Services/Logging/Logger.cs (+65 -0)
📝 src/Core/Services/Logging/LoggerHelper.cs (+2 -4)
📝 src/Core/Services/Logging/StubLogger.cs (+7 -0)
📝 src/iOS.Autofill/CredentialProviderViewController.cs (+1 -6)
➖ src/iOS.Core/Utilities/AppCenterHelper.cs (+0 -56)
📝 src/iOS.Core/Utilities/iOSCoreHelpers.cs (+2 -7)
📝 src/iOS.Core/iOS.Core.csproj (+0 -1)
📝 src/iOS.Extension/LoadingViewController.cs (+1 -6)

...and 2 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add a new entry in settings to allow user to disable sending information of crash reports to Appcenter.

Code changes

  • SettingsPageViewModel.cs: Added new method, AppCenterReportingAsync, to handle activation and deactivation of Crashes SDK. All changes are protected by compilation tags and shouldn't appear in FDroid build or Debug (Appcenter is only running in release compilations).
  • SettingsPage.xaml: Add call to AppCenterReportingAsync

Testing Requirements

Note: This change will only not appear in Debug or FDroid builds.

  1. Login into your account
  2. Go to Settings tab
  3. Scroll down to Others section
  4. Click on Report crash logs

Screenshots

image image

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1905 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 5/12/2022 **Status:** ✅ Merged **Merged:** 5/18/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `feature/appcenter-toggle` --- ### 📝 Commits (7) - [`16e7921`](https://github.com/bitwarden/android/commit/16e792130122f5758cef30d9f43f1578f0c1cd67) PS-518 - Add setting to block AppCenter / Analytics - Mobile - [`cf8cbff`](https://github.com/bitwarden/android/commit/cf8cbff0d4ec26b2361bccbf0a4cfa7b39741a62) PS-518 Add setting to block AppCenter / Analytics - Mobile - [`23aebde`](https://github.com/bitwarden/android/commit/23aebde86fccacc7f419f925a30005b16d4b2fd4) PS-518 Add setting to block AppCenter / Analytics - Mobile - [`2ae1167`](https://github.com/bitwarden/android/commit/2ae1167a5a54efdb75296af5c9ba558170dcfd8f) PS-518 Add setting to block AppCenter / Analytics - Mobile - [`42b0419`](https://github.com/bitwarden/android/commit/42b04198a8cc92a7430a73f7e4dccde36570651d) PS-518 Add setting to block AppCenter / Analytics - Mobile - [`71dd79f`](https://github.com/bitwarden/android/commit/71dd79f3cb149ea31ab8b3ced3f65edbd4b71ac9) PS-518 Add setting to block AppCenter / Analytics - Mobile - [`919dd5a`](https://github.com/bitwarden/android/commit/919dd5a3d671dd0a32daef5009d7c66fa27dd98f) PS-518 ### 📊 Changes **22 files changed** (+172 additions, -177 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+0 -12) 📝 `src/Android/Android.csproj` (+0 -1) 📝 `src/Android/MainActivity.cs` (+2 -4) 📝 `src/Android/Services/BiometricService.cs` (+4 -9) ➖ `src/Android/Utilities/AppCenterHelper.cs` (+0 -58) 📝 `src/App/App.csproj` (+0 -1) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPage.xaml.cs` (+4 -0) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+37 -3) 📝 `src/App/Resources/AppResources.Designer.cs` (+12 -0) 📝 `src/App/Resources/AppResources.resx` (+6 -0) 📝 `src/Core/Abstractions/ILogger.cs` (+18 -0) 📝 `src/Core/Services/Logging/DebugLogger.cs` (+7 -0) 📝 `src/Core/Services/Logging/Logger.cs` (+65 -0) 📝 `src/Core/Services/Logging/LoggerHelper.cs` (+2 -4) 📝 `src/Core/Services/Logging/StubLogger.cs` (+7 -0) 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+1 -6) ➖ `src/iOS.Core/Utilities/AppCenterHelper.cs` (+0 -56) 📝 `src/iOS.Core/Utilities/iOSCoreHelpers.cs` (+2 -7) 📝 `src/iOS.Core/iOS.Core.csproj` (+0 -1) 📝 `src/iOS.Extension/LoadingViewController.cs` (+1 -6) _...and 2 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Add a new entry in settings to allow user to disable sending information of crash reports to Appcenter. ## Code changes * **SettingsPageViewModel.cs:** Added new method, `AppCenterReportingAsync`, to handle activation and deactivation of Crashes SDK. All changes are protected by compilation tags and shouldn't appear in **FDroid** build or **Debug** (Appcenter is only running in release compilations). * **SettingsPage.xaml:** Add call to AppCenterReportingAsync ## Testing Requirements Note: This change will only not appear in **Debug** or **FDroid** builds. 1. Login into your account 2. Go to **Settings** tab 3. Scroll down to **Others** section 4. Click on **Report crash logs** ## Screenshots <img width="408" alt="image" src="https://user-images.githubusercontent.com/4648522/168031785-51f3302c-e3ca-41c2-83fc-dffb3d7559cb.png"> <img width="396" alt="image" src="https://user-images.githubusercontent.com/4648522/168031820-873dfd48-825e-4aa8-9879-8e9a51122a97.png"> ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:44 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3211
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?