github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-16 16:57:18 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1896] [MERGED] PS-330 Fix a11y issue with hCaptcha on iOS #3209

New Issue
Closed
opened 2025-11-26 23:29:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:43 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1896
Author: @mpbw2
Created: 4/28/2022
Status: ✅ Merged
Merged: 4/28/2022
Merged by: @mpbw2

Base: master ← Head: bugfix-captcha-a11y

📝 Commits (1)

  • d280d78 fix a11y issue with hCaptcha on iOS

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 src/App/Pages/CaptchaProtectedViewModel.cs (+4 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

hCaptcha has an option to bypass captcha requests for accessibility purposes, but the flow requires access to existing cookies when using WebAuthenticator, which we previously disabled to prevent any unforeseen issues. This PR enables cookie access within the captcha flow to allow the accessibility bypass to function. (Note this was only an issue on iOS since PrefersEphemeralWebBrowserSession has no effect on Android)

Code changes

  • CaptchaProtectedViewModel.cs: Set PrefersEphemeralWebBrowserSession to false to allow access to existing cookies during captcha flow

Testing requirements

See PS-330 for details

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1896 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 4/28/2022 **Status:** ✅ Merged **Merged:** 4/28/2022 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-captcha-a11y` --- ### 📝 Commits (1) - [`d280d78`](https://github.com/bitwarden/android/commit/d280d780feca14294b150ed3b5ae36f7c9573321) fix a11y issue with hCaptcha on iOS ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/CaptchaProtectedViewModel.cs` (+4 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> hCaptcha has an option to bypass captcha requests for accessibility purposes, but the flow requires access to existing cookies when using `WebAuthenticator`, which we previously disabled to prevent any unforeseen issues. This PR enables cookie access within the captcha flow to allow the accessibility bypass to function. (Note this was only an issue on iOS since `PrefersEphemeralWebBrowserSession` has no effect on Android) ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CaptchaProtectedViewModel.cs:** Set `PrefersEphemeralWebBrowserSession` to false to allow access to existing cookies during captcha flow ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> See PS-330 for details ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:43 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3209
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?