github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 88 Wiki Activity

[PR #1878] [MERGED] [BEEEP] [PS-262] add context to search titles #3194

New Issue
Closed
opened 2025-11-26 23:29:31 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:31 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1878
Author: @jlf0dev
Created: 4/8/2022
Status: ✅ Merged
Merged: 4/10/2022
Merged by: @jlf0dev

Base: master ← Head: beeep-search-titles

📝 Commits (3)

  • fc08786 add more descriptive titles to search pages
  • 418155e Merge branch 'master' into beeep-search-titles
  • ee40900 add App Resources

📊 Changes

6 files changed (+37 additions, -31 deletions)

View changed files

📝 src/App/Pages/Send/SendGroupingsPage/SendGroupingsPage.xaml.cs (+1 -1)
📝 src/App/Pages/Send/SendsPage.xaml.cs (+12 -3)
📝 src/App/Pages/Vault/CiphersPage.xaml.cs (+4 -16)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs (+1 -2)
📝 src/App/Resources/AppResources.Designer.cs (+10 -4)
📝 src/App/Resources/AppResources.resx (+9 -5)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Currently, search screens in our clients use generic titles such as “Search collection” or “Search folder”. In desktop and browser the folder name is shown but in mobile there is no clue as to which folder, collection, or item type you are searching for.

This PR adds the name of the collection/folder/type to the title of the page in mobile. For Sends, it also adds whether its a Text or File Send.

Code changes

  • src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs: Pass the page title to search screen
  • src/App/Pages/Vault/CiphersPage.xaml.cs: Removes previous titles and uses page title instead
  • src/App/Pages/Send/SendGroupingsPage/SendGroupingsPage.xaml.cs: Passes the type of Send to the search screen
  • src/App/Pages/Send/SendsPage.xaml.cs: Uses type of Send as search screen title

Screenshots

https://user-images.githubusercontent.com/24985544/162494216-880e1b41-5281-4012-840f-87d16ab7d462.mov

https://user-images.githubusercontent.com/24985544/162494239-f4fe54bc-0712-4776-aa8e-580e8d8bd957.mp4

Testing requirements

  • Test search titles for correct names

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1878 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 4/8/2022 **Status:** ✅ Merged **Merged:** 4/10/2022 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `beeep-search-titles` --- ### 📝 Commits (3) - [`fc08786`](https://github.com/bitwarden/android/commit/fc08786846e79f2ab137514a322e70088e242897) add more descriptive titles to search pages - [`418155e`](https://github.com/bitwarden/android/commit/418155eac41a2f92bde7b1ae05d9293288f9bfec) Merge branch 'master' into beeep-search-titles - [`ee40900`](https://github.com/bitwarden/android/commit/ee40900b696007c48ba7f57d61b81a809ff4db44) add App Resources ### 📊 Changes **6 files changed** (+37 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Send/SendGroupingsPage/SendGroupingsPage.xaml.cs` (+1 -1) 📝 `src/App/Pages/Send/SendsPage.xaml.cs` (+12 -3) 📝 `src/App/Pages/Vault/CiphersPage.xaml.cs` (+4 -16) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs` (+1 -2) 📝 `src/App/Resources/AppResources.Designer.cs` (+10 -4) 📝 `src/App/Resources/AppResources.resx` (+9 -5) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [x] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Currently, search screens in our clients use generic titles such as “Search collection” or “Search folder”. In desktop and browser the folder name is shown but in mobile there is no clue as to which folder, collection, or item type you are searching for. This PR adds the name of the collection/folder/type to the title of the page in mobile. For Sends, it also adds whether its a Text or File Send. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs:** Pass the page title to search screen * **src/App/Pages/Vault/CiphersPage.xaml.cs:** Removes previous titles and uses page title instead * **src/App/Pages/Send/SendGroupingsPage/SendGroupingsPage.xaml.cs:** Passes the type of Send to the search screen * **src/App/Pages/Send/SendsPage.xaml.cs:** Uses type of Send as search screen title ## Screenshots <!--Required for any UI changes. Delete if not applicable--> https://user-images.githubusercontent.com/24985544/162494216-880e1b41-5281-4012-840f-87d16ab7d462.mov https://user-images.githubusercontent.com/24985544/162494239-f4fe54bc-0712-4776-aa8e-580e8d8bd957.mp4 ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> - Test search titles for correct names ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:31 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3194
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?