github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 90 Wiki Activity

[PR #1856] [MERGED] Fix crash iOS AppDelegate OnActivated #3184

New Issue
Closed
opened 2025-11-26 23:29:23 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:23 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1856
Author: @fedemkr
Created: 3/21/2022
Status: ✅ Merged
Merged: 3/21/2022
Merged by: @fedemkr

Base: master ← Head: fix-ios-crash-onactivated

📝 Commits (1)

  • d5d7d2c Added null checks for iOS crash OnActivated on KeyWindow

📊 Changes

1 file changed (+6 additions, -6 deletions)

View changed files

📝 src/iOS/AppDelegate.cs (+6 -6)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix crash happened on AppDelegate -> OnActivated

Code changes

  • AppDelegate: Added null check on OnActivated for the KeyWindow and also made a const for the tag of the splash view.

Testing requirements

The flow for the crash to happen is unknown but at least we should check that the splash shown when "minimizing" the app should be displayed correctly and hide correctly when going back to the application.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1856 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/21/2022 **Status:** ✅ Merged **Merged:** 3/21/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `fix-ios-crash-onactivated` --- ### 📝 Commits (1) - [`d5d7d2c`](https://github.com/bitwarden/android/commit/d5d7d2c2ac09b7913a85620e766504e6b7eedcd2) Added null checks for iOS crash OnActivated on KeyWindow ### 📊 Changes **1 file changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS/AppDelegate.cs` (+6 -6) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix crash happened on `AppDelegate -> OnActivated` ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AppDelegate:** Added null check on `OnActivated` for the `KeyWindow` and also made a const for the `tag` of the splash view. ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> The flow for the crash to happen is unknown but at least we should check that the splash shown when "minimizing" the app should be displayed correctly and hide correctly when going back to the application. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:23 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3184
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?