github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-17 12:36:15 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #1835] [MERGED] Prevent tapping on app area if its obscured by another window #3167

New Issue
Closed
opened 2025-11-26 23:29:10 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:10 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1835
Author: @fedemkr
Created: 3/9/2022
Status: ✅ Merged
Merged: 3/10/2022
Merged by: @fedemkr

Base: master ← Head: bug/android-tapjacking

📝 Commits (2)

  • 8bb0867 Prevent touches when root view is obscured by another screen on Android
  • 839ef2c Merge branch 'master' into bug/android-tapjacking

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 src/Android/MainActivity.cs (+6 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Prevent tap actions from being redirected/missed when another view is obscuring the Bitwarden app.
Right now I've enabled it app wide but I do have stashed code to apply it for specific controls if we need to apply in a more granular way.

Code changes

  • MainActivity.cs: Enabled FilterTouchesWhenObscured on the root view so nothing on the app is tappable if it's obscured by another toast, dialog, or window (other app)

Testing requirements

Use an app that has a transparent or semi-transparent background to interact with Bitwarden app and check whether the controls are tapped like buttons, fields, etc.
If you don't have an app to test this let me know and I'll build a apk with the one I crerated and been using.
Also test to interact with the app when popups/dialogs and toasts are shown to see that I haven't broken anything.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1835 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/9/2022 **Status:** ✅ Merged **Merged:** 3/10/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `bug/android-tapjacking` --- ### 📝 Commits (2) - [`8bb0867`](https://github.com/bitwarden/android/commit/8bb08671060ac00a2306edf83d73c6d2f68f97f8) Prevent touches when root view is obscured by another screen on Android - [`839ef2c`](https://github.com/bitwarden/android/commit/839ef2cfbb4ed83885605b673a06bff0dca42a14) Merge branch 'master' into bug/android-tapjacking ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainActivity.cs` (+6 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Prevent tap actions from being redirected/missed when another view is obscuring the Bitwarden app. Right now I've enabled it app wide but I do have stashed code to apply it for specific controls if we need to apply in a more granular way. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **MainActivity.cs:** Enabled `FilterTouchesWhenObscured` on the root view so nothing on the app is tappable if it's obscured by another toast, dialog, or window (other app) ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> Use an app that has a transparent or semi-transparent background to interact with Bitwarden app and check whether the controls are tapped like buttons, fields, etc. If you don't have an app to test this let me know and I'll build a apk with the one I crerated and been using. Also test to interact with the app when popups/dialogs and toasts are shown to see that I haven't broken anything. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:10 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3167
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?