github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-17 12:36:15 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #1829] [CLOSED] [AuthService refactor] Mobile #3161

New Issue
Closed
opened 2025-11-26 23:29:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:06 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1829
Author: @eliykat
Created: 3/7/2022
Status: ❌ Closed

Base: master ← Head: refactor/authService-2

📝 Commits (9)

  • 9f379b9 Add TokenRequest base and sub classes
  • 69cb26d Add LogInCredentials
  • b3172f6 Start to add LogInStrategies
  • ecc33d6 Merge branch 'master' into refactor/authService-2
  • 1d79c2a Finish basic copy across of logInStrategies
  • 372d75d TwoFactorService
  • 026086e Register and init twoFactorService
  • cf86c77 Refactor authService itself
  • 3370d44 Fix various compile errors

📊 Changes

23 files changed (+4639 additions, -483 deletions)

View changed files

📝 src/Android/MainApplication.cs (+1 -1)
📝 src/App/Resources/AppResources.Designer.cs (+12 -0)
📝 src/App/Resources/AppResources.resx (+3 -0)
📝 src/App/Resources/AppResources.sv.Designer.cs (+3818 -0)
📝 src/Core/Abstractions/IApiService.cs (+1 -0)
📝 src/Core/Abstractions/IAuthService.cs (+7 -18)
➕ src/Core/Abstractions/ITwoFactorService.cs (+23 -0)
📝 src/Core/Core.csproj (+6 -0)
➕ src/Core/Misc/LogInStrategies/LogInStrategy.cs (+197 -0)
➕ src/Core/Misc/LogInStrategies/PasswordLogInStrategy.cs (+70 -0)
➕ src/Core/Misc/LogInStrategies/SsoLogInStrategy.cs (+59 -0)
📝 src/Core/Models/Domain/AuthResult.cs (+2 -2)
➕ src/Core/Models/Domain/LogInCredentials.cs (+43 -0)
➕ src/Core/Models/Request/IdentityToken/PasswordTokenRequest.cs (+45 -0)
➕ src/Core/Models/Request/IdentityToken/SsoTokenRequest.cs (+30 -0)
➕ src/Core/Models/Request/IdentityToken/TokenRequest.cs (+52 -0)
➕ src/Core/Models/Request/IdentityToken/TokenRequestTwoFactor.cs (+15 -0)
➖ src/Core/Models/Request/TokenRequest.cs (+0 -99)
📝 src/Core/Services/ApiService.cs (+1 -0)
📝 src/Core/Services/AuthService.cs (+71 -362)

...and 3 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Testing requirements

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1829 **Author:** [@eliykat](https://github.com/eliykat) **Created:** 3/7/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `refactor/authService-2` --- ### 📝 Commits (9) - [`9f379b9`](https://github.com/bitwarden/android/commit/9f379b949187783e54cafa35f00542372fd476c2) Add TokenRequest base and sub classes - [`69cb26d`](https://github.com/bitwarden/android/commit/69cb26d99fbcf6733246ac7f7f94dba9e91e080f) Add LogInCredentials - [`b3172f6`](https://github.com/bitwarden/android/commit/b3172f66de5d9ec3dc700c52f131062ba87635d9) Start to add LogInStrategies - [`ecc33d6`](https://github.com/bitwarden/android/commit/ecc33d6a7bc69a19742367c9843f2223bc2f15a2) Merge branch 'master' into refactor/authService-2 - [`1d79c2a`](https://github.com/bitwarden/android/commit/1d79c2ad4b175f500fbae22724e593227758b32b) Finish basic copy across of logInStrategies - [`372d75d`](https://github.com/bitwarden/android/commit/372d75d570e792570ca825b1320436c563caa011) TwoFactorService - [`026086e`](https://github.com/bitwarden/android/commit/026086ec24c11a930953edcb037e0dae1881d1df) Register and init twoFactorService - [`cf86c77`](https://github.com/bitwarden/android/commit/cf86c778ee8dc8816bd2b16d6903b7804b69a7d9) Refactor authService itself - [`3370d44`](https://github.com/bitwarden/android/commit/3370d44b9f35f461a6efc4f1cfa9a016de0e3121) Fix various compile errors ### 📊 Changes **23 files changed** (+4639 additions, -483 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainApplication.cs` (+1 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+12 -0) 📝 `src/App/Resources/AppResources.resx` (+3 -0) 📝 `src/App/Resources/AppResources.sv.Designer.cs` (+3818 -0) 📝 `src/Core/Abstractions/IApiService.cs` (+1 -0) 📝 `src/Core/Abstractions/IAuthService.cs` (+7 -18) ➕ `src/Core/Abstractions/ITwoFactorService.cs` (+23 -0) 📝 `src/Core/Core.csproj` (+6 -0) ➕ `src/Core/Misc/LogInStrategies/LogInStrategy.cs` (+197 -0) ➕ `src/Core/Misc/LogInStrategies/PasswordLogInStrategy.cs` (+70 -0) ➕ `src/Core/Misc/LogInStrategies/SsoLogInStrategy.cs` (+59 -0) 📝 `src/Core/Models/Domain/AuthResult.cs` (+2 -2) ➕ `src/Core/Models/Domain/LogInCredentials.cs` (+43 -0) ➕ `src/Core/Models/Request/IdentityToken/PasswordTokenRequest.cs` (+45 -0) ➕ `src/Core/Models/Request/IdentityToken/SsoTokenRequest.cs` (+30 -0) ➕ `src/Core/Models/Request/IdentityToken/TokenRequest.cs` (+52 -0) ➕ `src/Core/Models/Request/IdentityToken/TokenRequestTwoFactor.cs` (+15 -0) ➖ `src/Core/Models/Request/TokenRequest.cs` (+0 -99) 📝 `src/Core/Services/ApiService.cs` (+1 -0) 📝 `src/Core/Services/AuthService.cs` (+71 -362) _...and 3 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3161
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?