github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-12 14:51:15 -05:00
Code Issues 1.1k Packages Projects Releases 124 Wiki Activity

[PR #1800] [MERGED] Improved keyboard UX on Identity fields #3136

New Issue
Closed
opened 2025-11-26 23:28:45 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:45 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1800
Author: @fedemkr
Created: 2/23/2022
Status: ✅ Merged
Merged: 2/23/2022
Merged by: @fedemkr

Base: master ← Head: ux/improve-keyboard-on-add-edit-identity-fields

📝 Commits (1)

  • b3e74e2 Changed Input keyboard on phone to be the telephone keyboard and also capitalized the keyboard on some fields of add/edit identity

📊 Changes

2 files changed (+31 additions, -6 deletions)

View changed files

📝 src/App/Pages/Vault/AddEditPage.xaml (+7 -6)
📝 src/App/Styles/Base.xaml (+24 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Improve UX on Identity fields, to have phone keyboard and capitalize names and city/state/country. Based on https://github.com/bitwarden/web/pull/1384

Code changes

  • Base.xaml: Added styles for capitalize word/sentence
  • AddEditPage.xaml: Changed styles for better keyboard UX

Screenshots

Screenshot_20220223-104916
Screenshot_20220223-104944
Screenshot_20220223-104953

Testing requirements

On First name, Middle Name and Last Name the keyboard should appear capitalizing each word.
On Phone should open the telephone keyboard
On City, State and Country the keyboard should appear capitalizing the sentence.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1800 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 2/23/2022 **Status:** ✅ Merged **Merged:** 2/23/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `ux/improve-keyboard-on-add-edit-identity-fields` --- ### 📝 Commits (1) - [`b3e74e2`](https://github.com/bitwarden/android/commit/b3e74e28f2396ec0c9b62fce5be8c4bb45504f18) Changed Input keyboard on phone to be the telephone keyboard and also capitalized the keyboard on some fields of add/edit identity ### 📊 Changes **2 files changed** (+31 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/AddEditPage.xaml` (+7 -6) 📝 `src/App/Styles/Base.xaml` (+24 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Improve UX on Identity fields, to have phone keyboard and capitalize names and city/state/country. Based on [https://github.com/bitwarden/web/pull/1384](https://github.com/bitwarden/web/pull/1384) ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **Base.xaml:** Added styles for capitalize word/sentence * **AddEditPage.xaml:** Changed styles for better keyboard UX ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ![Screenshot_20220223-104916](https://user-images.githubusercontent.com/15682323/155332581-1b21d963-932f-4059-8c39-315bb6454b2c.png) ![Screenshot_20220223-104944](https://user-images.githubusercontent.com/15682323/155332588-b1d08f7b-e15c-4ae7-9258-0ed65a731d0a.png) ![Screenshot_20220223-104953](https://user-images.githubusercontent.com/15682323/155332595-be7b3a20-152d-4d7d-94e0-16e50959dc9c.png) ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> On First name, Middle Name and Last Name the keyboard should appear capitalizing each word. On Phone should open the telephone keyboard On City, State and Country the keyboard should appear capitalizing the sentence. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:45 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3136
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?