github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-18 23:16:54 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #1795] [MERGED] Fix vault item icon image size to be adaptive on Large Font Size Accessibility #3132

New Issue
Closed
opened 2025-11-26 23:28:42 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:42 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1795
Author: @fedemkr
Created: 2/21/2022
Status: ✅ Merged
Merged: 2/22/2022
Merged by: @fedemkr

Base: master ← Head: fix-large-font-size-row-height

📝 Commits (3)

  • 2d78f6e Fix icon image size to be adaptive on Large Font Size Accessibility which fixes row height on large vault
  • 51828cf Merge branch 'master' into fix-large-font-size-row-height
  • b1fc775 Added consts to improve the code

📊 Changes

2 files changed (+12 additions, -6 deletions)

View changed files

📝 src/App/Controls/CipherViewCell/CipherViewCell.xaml (+5 -4)
📝 src/App/Controls/CipherViewCell/CipherViewCell.xaml.cs (+7 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix icon image size to be adaptive on Large Font Size Accessibility which also fixes the row height being really high on large vault items.

Code changes

  • CipherViewCell: Change the Width/HeightrRequest of the CachedImage icon to be calculated with the font scale.

Screenshots

Before:

image

After:

image image

Testing requirements

Test that the icons have the correct size and check this on large vault as well.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1795 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 2/21/2022 **Status:** ✅ Merged **Merged:** 2/22/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `fix-large-font-size-row-height` --- ### 📝 Commits (3) - [`2d78f6e`](https://github.com/bitwarden/android/commit/2d78f6e3e4ebaeb1c72698538af391662799cfbe) Fix icon image size to be adaptive on Large Font Size Accessibility which fixes row height on large vault - [`51828cf`](https://github.com/bitwarden/android/commit/51828cfe0770c78a9e5a1b8376922b27ca3706a1) Merge branch 'master' into fix-large-font-size-row-height - [`b1fc775`](https://github.com/bitwarden/android/commit/b1fc775729a807cb75841d966ac017c15620e169) Added consts to improve the code ### 📊 Changes **2 files changed** (+12 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/CipherViewCell/CipherViewCell.xaml` (+5 -4) 📝 `src/App/Controls/CipherViewCell/CipherViewCell.xaml.cs` (+7 -2) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix icon image size to be adaptive on Large Font Size Accessibility which also fixes the row height being really high on large vault items. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CipherViewCell:** Change the Width/HeightrRequest of the CachedImage icon to be calculated with the font scale. ## Screenshots ### Before: <!--Required for any UI changes. Delete if not applicable--> ![image](https://user-images.githubusercontent.com/15682323/154976733-4198aac6-02a5-4435-a821-a2ba9bab61f0.png) ### After: <img width="374" alt="image" src="https://user-images.githubusercontent.com/15682323/154977322-f1439ab3-09d5-44de-9175-418c3b671c5d.png"> <img width="377" alt="image" src="https://user-images.githubusercontent.com/15682323/154977383-cd2723d0-5c90-4bca-88e7-46eab6c6a548.png"> ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> Test that the icons have the correct size and check this on large vault as well. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:42 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3132
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?