github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 03:01:21 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #1782] [MERGED] Fix Password Generator view bottom truncated Large Font Size #3122

New Issue
Closed
opened 2025-11-26 23:28:35 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:35 -06:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1782
Author: @fedemkr
Created: 2/15/2022
Status: ✅ Merged
Merged: 2/15/2022
Merged by: @fedemkr

Base: master ← Head: bug/android-large-font-size-pass-gen

📝 Commits (1)

  • 3a615d3 Fix truncated bottom on Password generator when large font size is set on Android

📊 Changes

2 files changed (+241 additions, -237 deletions)

View changed files

📝 src/App/Pages/Generator/GeneratorPage.xaml (+240 -236)
📝 src/App/Styles/Base.xaml (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

On Android, when Large Font Size settings is set, the password generator view gets truncated at the bottom; so this PR fix this and also that the Length number width is correct to be displayed in one line.

Also we should keep track of Xamarin Forms PR: Make sure ScrollViewRenderer on Android is resolving layout changes. That should be released shortly, that should fix this without the workaround.

Code changes

  • GeneratorPage.xaml: Wrapped the ScrollView in a ContentView (workaround) so that the layout measurements get updated with Large font size. And also increased WidthRequest on the Length to be displayed correctly in one line.

Testing requirements

Go to Android Accessibility settings and increase the font size and the bottom of the password generator view shouldn't be truncated.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1782 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 2/15/2022 **Status:** ✅ Merged **Merged:** 2/15/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `bug/android-large-font-size-pass-gen` --- ### 📝 Commits (1) - [`3a615d3`](https://github.com/bitwarden/android/commit/3a615d3dbf267bda39f6ccc0c5cf7fe43961d54b) Fix truncated bottom on Password generator when large font size is set on Android ### 📊 Changes **2 files changed** (+241 additions, -237 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Generator/GeneratorPage.xaml` (+240 -236) 📝 `src/App/Styles/Base.xaml` (+1 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> On Android, when Large Font Size settings is set, the password generator view gets truncated at the bottom; so this PR fix this and also that the `Length` number width is correct to be displayed in one line. Also **we should keep track** of Xamarin Forms PR: [Make sure ScrollViewRenderer on Android is resolving layout changes](https://github.com/xamarin/Xamarin.Forms/pull/15076). That should be released shortly, that should fix this without the workaround. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **GeneratorPage.xaml:** Wrapped the `ScrollView` in a `ContentView` (_workaround_) so that the layout measurements get updated with Large font size. And also increased `WidthRequest` on the `Length` to be displayed correctly in one line. ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> Go to Android Accessibility settings and increase the font size and the bottom of the password generator view shouldn't be truncated. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:35 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3122