github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-17 03:59:18 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #1773] [MERGED] [Icons] - BUG - Update groupings icon for collections #3114

New Issue
Closed
opened 2025-11-26 23:28:28 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:28 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1773
Author: @vincentsalucci
Created: 2/12/2022
Status: ✅ Merged
Merged: 2/12/2022
Merged by: @vvolkgang

Base: master ← Head: m-bug-collections

📝 Commits (1)

  • a5f6ca9 [Icons] - BUG - Update groupings icon for collections

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageListItem.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix the groupings icon for collections: bwi-globe --> bwi-collection

Code changes

  • GroupingsPageListItem: Changed icon for collections to BitwardenIcons.Collection

Screenshots

  • Reference for correct icon
    Screen Shot 2022-02-11 at 11 09 57 PM

Testing requirements

  • Make sure that the icon for collections within the groupings page is using the correct icon

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1773 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 2/12/2022 **Status:** ✅ Merged **Merged:** 2/12/2022 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `master` ← **Head:** `m-bug-collections` --- ### 📝 Commits (1) - [`a5f6ca9`](https://github.com/bitwarden/android/commit/a5f6ca9cef2e62c3b95d918f2ab6dc7c1c4b1868) [Icons] - BUG - Update groupings icon for collections ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageListItem.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective > Fix the groupings icon for collections: `bwi-globe` --> `bwi-collection` ## Code changes - **GroupingsPageListItem**: Changed icon for collections to `BitwardenIcons.Collection` ## Screenshots - Reference for correct icon <img width="365" alt="Screen Shot 2022-02-11 at 11 09 57 PM" src="https://user-images.githubusercontent.com/26154748/153697705-94dd54ed-4308-471a-8e92-06f22c6c516f.png"> ## Testing requirements - Make sure that the icon for collections within the groupings page is using the correct icon ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:28 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3114
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?