github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1771] [MERGED] Add AppCenter secret to build workflow #3113

New Issue
Closed
opened 2025-11-26 23:28:27 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:27 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1771
Author: @vgrassia
Created: 2/11/2022
Status: ✅ Merged
Merged: 2/11/2022
Merged by: @vgrassia

Base: add-dsym-build ← Head: update-build-workflow

📝 Commits (1)

  • f431d66 Add secret to build workflow

📊 Changes

1 file changed (+13 additions, -1 deletions)

View changed files

📝 .github/workflows/build.yml (+13 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR adds the iOS AppCenter secret to the build workflow.

Code changes

  • .github/workflows/build.yml: Added login/key-vault steps to iOS job and used new secret in Upload dSYMs to App Center step.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1771 **Author:** [@vgrassia](https://github.com/vgrassia) **Created:** 2/11/2022 **Status:** ✅ Merged **Merged:** 2/11/2022 **Merged by:** [@vgrassia](https://github.com/vgrassia) **Base:** `add-dsym-build` ← **Head:** `update-build-workflow` --- ### 📝 Commits (1) - [`f431d66`](https://github.com/bitwarden/android/commit/f431d66aa49739bc331c414c93728ccae1e72de0) Add secret to build workflow ### 📊 Changes **1 file changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+13 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [X] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> This PR adds the `iOS AppCenter` secret to the `build` workflow. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **.github/workflows/build.yml:** Added login/key-vault steps to `iOS` job and used new secret in `Upload dSYMs to App Center` step. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [X] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:27 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3113
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?