github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-17 12:36:15 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #1755] [MERGED] Dismiss Account Switching overlay when tapping on the tabs #3099

New Issue
Closed
opened 2025-11-26 23:28:16 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:16 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1755
Author: @fedemkr
Created: 2/7/2022
Status: ✅ Merged
Merged: 2/8/2022
Merged by: @fedemkr

Base: accountswitching ← Head: accountswitching-tabs-tap-to-dismiss

📝 Commits (2)

  • 521cec3 Implemented dismiss account switching overlay when changing tabs and when selecting the same tab. Also updated the deprecated listener on CustomTabbedRenderer on Android
  • bfaed9d Merge branch 'accountswitching' into accountswitching-tabs-tap-to-dismiss

📊 Changes

4 files changed (+50 additions, -4 deletions)

View changed files

📝 src/Android/Renderers/CustomTabbedRenderer.cs (+8 -2)
📝 src/App/Pages/TabsPage.cs (+14 -1)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs (+5 -0)
📝 src/iOS.Core/Renderers/CustomTabbedRenderer.cs (+23 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Dismiss the Account Switching Overlay when tapping on the tabs.

Merge #1753 before merging this so the call to hide the overlay gets updated in the new way the other PR has.

Code changes

  • TabsPage: Implemented call to hide the overlay on the GroupingsPage on tab re-selection and when changing tabs
  • Android/Renderers/CustomTabbedRenderer.cs: Called hide the overlay on tab re-selection and updated the deprecated listener.
  • /iOS.Core/Renderers/CustomTabbedRenderer.cs: Called hide the overlay on tab re-selection
  • GroupigsPage.xaml.cs: Made pubic method to hide the overlay (this needs to change when #1753 gets merged)

Testing requirements

When the overlay is open and you tap on a tab, the overlay should hide.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1755 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 2/7/2022 **Status:** ✅ Merged **Merged:** 2/8/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `accountswitching` ← **Head:** `accountswitching-tabs-tap-to-dismiss` --- ### 📝 Commits (2) - [`521cec3`](https://github.com/bitwarden/android/commit/521cec34c3eb9bffe45c3c4fcc72cb57d19322fe) Implemented dismiss account switching overlay when changing tabs and when selecting the same tab. Also updated the deprecated listener on CustomTabbedRenderer on Android - [`bfaed9d`](https://github.com/bitwarden/android/commit/bfaed9d8199db0d9e940e8e8d5ce81f608233315) Merge branch 'accountswitching' into accountswitching-tabs-tap-to-dismiss ### 📊 Changes **4 files changed** (+50 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Renderers/CustomTabbedRenderer.cs` (+8 -2) 📝 `src/App/Pages/TabsPage.cs` (+14 -1) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs` (+5 -0) 📝 `src/iOS.Core/Renderers/CustomTabbedRenderer.cs` (+23 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Dismiss the Account Switching Overlay when tapping on the tabs. **Merge #1753 before merging this so the call to hide the overlay gets updated in the new way the other PR has.** ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **TabsPage:** Implemented call to hide the overlay on the `GroupingsPage` on tab re-selection and when changing tabs * **Android/Renderers/CustomTabbedRenderer.cs:** Called hide the overlay on tab re-selection and updated the deprecated listener. * **/iOS.Core/Renderers/CustomTabbedRenderer.cs:** Called hide the overlay on tab re-selection * **GroupigsPage.xaml.cs:** Made pubic method to hide the overlay (this needs to change when #1753 gets merged) ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> When the overlay is open and you tap on a tab, the overlay should hide. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:16 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3099
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?