github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-13 23:31:21 -05:00
Code Issues 1.1k Packages Projects Releases 124 Wiki Activity

[PR #1747] [MERGED] Removed punctuation on some string resources regarding Send #3093

New Issue
Closed
opened 2025-11-26 23:28:12 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:12 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1747
Author: @fedemkr
Created: 2/2/2022
Status: ✅ Merged
Merged: 2/2/2022
Merged by: @fedemkr

Base: master ← Head: remove-punctuation-share-ios

📝 Commits (1)

  • 614b4c7 Removed punctuation on some string resources regarding send

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 src/App/Resources/AppResources.resx (+3 -3)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Remove final punctuation on some strings for the Send view.

Code changes

  • AppResources.resx: Removed punctuation

Testing requirements

The final period should not be there on the strings that relate to the toggles on the Send screen

Bitwarden Send via the share icon menu

  • Open a file such as PDF or photo
  • select the share button in iOS then select Bitwarden
  • scroll to the bottom of the send and there are two toggle titles that should not have periods anymore

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1747 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 2/2/2022 **Status:** ✅ Merged **Merged:** 2/2/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `remove-punctuation-share-ios` --- ### 📝 Commits (1) - [`614b4c7`](https://github.com/bitwarden/android/commit/614b4c76856a4062d2fd778ef86674588b495819) Removed punctuation on some string resources regarding send ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Resources/AppResources.resx` (+3 -3) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Remove final punctuation on some strings for the Send view. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AppResources.resx:** Removed punctuation ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> The final period should not be there on the strings that relate to the toggles on the Send screen Bitwarden Send via the share icon menu - Open a file such as PDF or photo - select the share button in iOS then select Bitwarden - scroll to the bottom of the send and there are two toggle titles that should not have periods anymore ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:12 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3093
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?