github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1743] [MERGED] Account Switching Tap to dismiss #3090

New Issue
Closed
opened 2025-11-26 23:28:10 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:10 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1743
Author: @fedemkr
Created: 1/31/2022
Status: ✅ Merged
Merged: 2/1/2022
Merged by: @fedemkr

Base: accountswitching ← Head: accountswitching-tap-outside-to-dismiss

📝 Commits (4)

  • 18428b0 Added tap to dismiss on the Account switching overlay and improved a bit the code
  • 4e14a25 Merge branch 'accountswitching' into accountswitching-tap-outside-to-dismiss
  • 810e7b0 Fix account switching overlay background transparent on the proper place
  • 45aae0c Fixed transparent background and the shadow on the account switching overlay

📊 Changes

9 files changed (+312 additions, -136 deletions)

View changed files

📝 src/App/Pages/Accounts/HomePage.xaml (+31 -18)
📝 src/App/Pages/Accounts/HomePage.xaml.cs (+34 -6)
📝 src/App/Pages/Accounts/LockPage.xaml (+32 -19)
📝 src/App/Pages/Accounts/LockPage.xaml.cs (+33 -6)
📝 src/App/Pages/Accounts/LoginPage.xaml (+31 -18)
📝 src/App/Pages/Accounts/LoginPage.xaml.cs (+33 -6)
📝 src/App/Pages/BaseContentPage.cs (+48 -32)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml (+31 -18)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs (+39 -13)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add tap to dismiss on the Account Switching list when tapping outside the list on the overlay.

Code changes

  • BaseContentPage.cs: Renamed ShowAccountListAsync to ToggleAccountListAsync handling the IsVisible inside from the overlay reference thus reducing the boilerplate from the callers. Added two new methods ShowAccountListAsync and HideAccountListAsync to be used directly where they are needed.
  • ...Page.xaml: Added BoxView to add the tap gesture and dismiss the overlay
  • ...Page.xaml.cs: Added behavior to dismiss the overlay on tapping and improved the code to reduce boilerplate

Testing requirements

When the Account Switching overlay list is opened, tapping on the bottom part should close it.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1743 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 1/31/2022 **Status:** ✅ Merged **Merged:** 2/1/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `accountswitching` ← **Head:** `accountswitching-tap-outside-to-dismiss` --- ### 📝 Commits (4) - [`18428b0`](https://github.com/bitwarden/android/commit/18428b06b4c85d7246158ebac8f9ff9350e9ef35) Added tap to dismiss on the Account switching overlay and improved a bit the code - [`4e14a25`](https://github.com/bitwarden/android/commit/4e14a2512e6d544eaadcabe9a5794bb06127ec70) Merge branch 'accountswitching' into accountswitching-tap-outside-to-dismiss - [`810e7b0`](https://github.com/bitwarden/android/commit/810e7b09b1e665f40852bbcb16dece91b981ed66) Fix account switching overlay background transparent on the proper place - [`45aae0c`](https://github.com/bitwarden/android/commit/45aae0c22b79356ccec46d0a96b146099858e998) Fixed transparent background and the shadow on the account switching overlay ### 📊 Changes **9 files changed** (+312 additions, -136 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/HomePage.xaml` (+31 -18) 📝 `src/App/Pages/Accounts/HomePage.xaml.cs` (+34 -6) 📝 `src/App/Pages/Accounts/LockPage.xaml` (+32 -19) 📝 `src/App/Pages/Accounts/LockPage.xaml.cs` (+33 -6) 📝 `src/App/Pages/Accounts/LoginPage.xaml` (+31 -18) 📝 `src/App/Pages/Accounts/LoginPage.xaml.cs` (+33 -6) 📝 `src/App/Pages/BaseContentPage.cs` (+48 -32) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml` (+31 -18) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs` (+39 -13) </details> ### 📄 Description ## Type of change - [X] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add tap to dismiss on the Account Switching list when tapping outside the list on the overlay. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **BaseContentPage.cs:** Renamed `ShowAccountListAsync` to `ToggleAccountListAsync` handling the `IsVisible` inside from the overlay reference thus reducing the boilerplate from the callers. Added two new methods `ShowAccountListAsync` and `HideAccountListAsync` to be used directly where they are needed. * **...Page.xaml:** Added `BoxView` to add the tap gesture and dismiss the overlay * **...Page.xaml.cs:** Added behavior to dismiss the overlay on tapping and improved the code to reduce boilerplate ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> When the Account Switching overlay list is opened, tapping on the bottom part should close it. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:10 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3090
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?