github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 06:59:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1739] [MERGED] Clear Console.WriteLine logs on iOS push notifications #3086

New Issue
Closed
opened 2025-11-26 23:28:07 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:07 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1739
Author: @fedemkr
Created: 1/31/2022
Status: ✅ Merged
Merged: 1/31/2022
Merged by: @fedemkr

Base: master ← Head: remove-logs-ios-pn

📝 Commits (1)

  • 680d1a4 Cleared Console.WriteLine for iOS push notifications issue

📊 Changes

4 files changed (+23 additions, -33 deletions)

View changed files

📝 src/App/Services/PushNotificationListenerService.cs (+11 -10)
📝 src/iOS/AppDelegate.cs (+0 -8)
📝 src/iOS/Services/iOSPushNotificationHandler.cs (+6 -8)
📝 src/iOS/Services/iOSPushNotificationService.cs (+6 -7)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Clear the logs added previously to debug iOS push notifications

Code changes

  • Clear logs changing them to Debug.WriteLine(...)

Testing requirements

No logs regarding "## PUSH NOTIFICATIONS" should be output on the Console

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1739 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 1/31/2022 **Status:** ✅ Merged **Merged:** 1/31/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `remove-logs-ios-pn` --- ### 📝 Commits (1) - [`680d1a4`](https://github.com/bitwarden/android/commit/680d1a41bd5175e8863626a9198f3213ce1933d6) Cleared Console.WriteLine for iOS push notifications issue ### 📊 Changes **4 files changed** (+23 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Services/PushNotificationListenerService.cs` (+11 -10) 📝 `src/iOS/AppDelegate.cs` (+0 -8) 📝 `src/iOS/Services/iOSPushNotificationHandler.cs` (+6 -8) 📝 `src/iOS/Services/iOSPushNotificationService.cs` (+6 -7) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Clear the logs added previously to debug iOS push notifications ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * Clear logs changing them to `Debug.WriteLine(...)` ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> No logs regarding "## PUSH NOTIFICATIONS" should be output on the Console ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:07 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3086
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?