github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 13:07:48 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3615] [MERGED] [PM-9409] Complete FIDO 2 assertion with appropriate response #30294

New Issue
Closed
opened 2026-04-18 14:05:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 14:05:51 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3615
Author: @SaintPatrck
Created: 7/23/2024
Status: ✅ Merged
Merged: 7/25/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-9409/fido2-completion-manager

📝 Commits (5)

  • c6cdc0c Complete FIDO 2 assertion with appropriate response
  • b6fd01a Sweet, sweet test coverage. Oh Yea!
  • 6a0af78 Detekt... smh
  • f85d841 Separate no-op tests
  • 2a23aa2 Apply suggestions

📊 Changes

6 files changed (+260 additions, -5 deletions)

View changed files

➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialAssertionResult.kt (+22 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManager.kt (+6 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerImpl.kt (+43 -4)
➕ app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerUnsupportedApiImpl.kt (+14 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt (+10 -1)
➕ app/src/test/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerTest.kt (+165 -0)

📄 Description

🎟️ Tracking

PM-9409

📔 Objective

Update Fido2CompletionManager to handle FIDO 2 assertion results and respond to the system based on the assertion result.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3615 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 7/23/2024 **Status:** ✅ Merged **Merged:** 7/25/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-9409/fido2-completion-manager` --- ### 📝 Commits (5) - [`c6cdc0c`](https://github.com/bitwarden/android/commit/c6cdc0ca7fa0d6e8a18a2ad8c4a45066b2b33c57) Complete FIDO 2 assertion with appropriate response - [`b6fd01a`](https://github.com/bitwarden/android/commit/b6fd01a919c47836eef5b684355f26404c8e0970) Sweet, sweet test coverage. Oh Yea! - [`6a0af78`](https://github.com/bitwarden/android/commit/6a0af782c81c268ee8bd6f8aef24a60665763282) Detekt... smh - [`f85d841`](https://github.com/bitwarden/android/commit/f85d841c0d77250b60b0425ee5c4f972c4d1031b) Separate no-op tests - [`2a23aa2`](https://github.com/bitwarden/android/commit/2a23aa231cf338e36e46f0ea30754215d6290306) Apply suggestions ### 📊 Changes **6 files changed** (+260 additions, -5 deletions) <details> <summary>View changed files</summary> ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialAssertionResult.kt` (+22 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManager.kt` (+6 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerImpl.kt` (+43 -4) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerUnsupportedApiImpl.kt` (+14 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt` (+10 -1) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerTest.kt` (+165 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-9409 ## 📔 Objective Update Fido2CompletionManager to handle FIDO 2 assertion results and respond to the system based on the assertion result. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 14:05:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#30294