github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1651] [MERGED] ui changes export vault screen for key connector #3029

New Issue
Closed
opened 2025-11-26 23:27:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:27:21 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1651
Author: @jlf0dev
Created: 11/18/2021
Status: ✅ Merged
Merged: 11/19/2021
Merged by: @jlf0dev

Base: master ← Head: bug/update-export-ui

📝 Commits (2)

  • 040a60e ui changes export vault screen for key connector
  • 44d854b update label and remove period

📊 Changes

4 files changed (+116 additions, -53 deletions)

View changed files

📝 src/App/Pages/Settings/ExportVaultPage.xaml (+63 -44)
📝 src/App/Pages/Settings/ExportVaultPageViewModel.cs (+18 -1)
📝 src/App/Resources/AppResources.Designer.cs (+22 -4)
📝 src/App/Resources/AppResources.resx (+13 -4)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Update Export Vault screen for those using key connector with OTP

Code changes

  • file.ext: Description of what was changed and why
  • src/App/Pages/Settings/ExportVaultPage.xaml: Update vault ui
  • src/App/Pages/Settings/ExportVaultPageViewModel.cs: Add success toast to code send and exception handling
  • src/App/Resources/AppResources.resx: Add resource strings

Screenshots

image

Testing requirements

  • Vault export functionality

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1651 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 11/18/2021 **Status:** ✅ Merged **Merged:** 11/19/2021 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `bug/update-export-ui` --- ### 📝 Commits (2) - [`040a60e`](https://github.com/bitwarden/android/commit/040a60e4d8dadfa67e6be87d2d221ec51b0bc055) ui changes export vault screen for key connector - [`44d854b`](https://github.com/bitwarden/android/commit/44d854b214731e795240901e338d21af190c28c6) update label and remove period ### 📊 Changes **4 files changed** (+116 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/ExportVaultPage.xaml` (+63 -44) 📝 `src/App/Pages/Settings/ExportVaultPageViewModel.cs` (+18 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+22 -4) 📝 `src/App/Resources/AppResources.resx` (+13 -4) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [x] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Update Export Vault screen for those using key connector with OTP ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why * **src/App/Pages/Settings/ExportVaultPage.xaml:** Update vault ui * **src/App/Pages/Settings/ExportVaultPageViewModel.cs:** Add success toast to code send and exception handling * **src/App/Resources/AppResources.resx:** Add resource strings ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ![image](https://user-images.githubusercontent.com/24985544/142490462-0d1fd740-2eb8-4185-9e33-cbe65544e000.png) ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> - Vault export functionality ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:27:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3029
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?