github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-16 17:14:25 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1649] [MERGED] Fixed missing FavIcons on Android #1640 #3027

New Issue
Closed
opened 2025-11-26 23:27:19 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:27:19 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1649
Author: @fedemkr
Created: 11/17/2021
Status: ✅ Merged
Merged: 11/18/2021
Merged by: @fedemkr

Base: master ← Head: favicons-android-handler-fix

📝 Commits (3)

  • c91488e Set custom HttpClient for FFImageLoading to set AndroidClientHandler in order to load icons from icon server due to a problem with the SSL certificate when using the default HttpClientHandler #1640
  • 451110d Using cleanup for FDroid #1640
  • 8489728 Added System.Net.Http on Android.csproj for FDroid only to check if that fixes the build

📊 Changes

2 files changed (+5 additions, -1 deletions)

View changed files

📝 src/Android/Android.csproj (+1 -0)
📝 src/Android/MainApplication.cs (+4 -1)

📄 Description

Type of change

Objective

Favicons were missed on the vault because of an SSL issue due to not setting AndroidClientHandler on the image library, FFImageLoading.

Discussion of the issue: https://github.com/xamarin/xamarin-android/issues/6351

Code changes

MainApplication.cs: Set AndroidClientHandler as the handler for the HttpClient to be used in the FFImageLoading service.

Screenshots

Testing requirements

Specially on Android API < 7.1.1 we should test that the vault icons are being loaded correctly.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1649 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 11/17/2021 **Status:** ✅ Merged **Merged:** 11/18/2021 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `favicons-android-handler-fix` --- ### 📝 Commits (3) - [`c91488e`](https://github.com/bitwarden/android/commit/c91488e229646211e2a99568a3fa6c2b181bb5f5) Set custom HttpClient for FFImageLoading to set AndroidClientHandler in order to load icons from icon server due to a problem with the SSL certificate when using the default HttpClientHandler #1640 - [`451110d`](https://github.com/bitwarden/android/commit/451110d9ed100a7529412c59e11e8f69d1b576a6) Using cleanup for FDroid #1640 - [`8489728`](https://github.com/bitwarden/android/commit/848972807779fd8c7c4dc3621820dc963ff49523) Added System.Net.Http on Android.csproj for FDroid only to check if that fixes the build ### 📊 Changes **2 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+1 -0) 📝 `src/Android/MainApplication.cs` (+4 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix #1640 - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Favicons were missed on the vault because of an SSL issue due to not setting AndroidClientHandler on the image library, FFImageLoading. Discussion of the issue: https://github.com/xamarin/xamarin-android/issues/6351 ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> **MainApplication.cs:** Set AndroidClientHandler as the handler for the HttpClient to be used in the FFImageLoading service. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> Specially on Android API < 7.1.1 we should test that the vault icons are being loaded correctly. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:27:19 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3027
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?