github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3539] [MERGED] [PM-9844] Android - Non-Premium Users Can Copy TOTP Code From Item Menu #30260

New Issue
Closed
opened 2026-04-18 14:04:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 14:04:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3539
Author: @dseverns-livefront
Created: 7/16/2024
Status: ✅ Merged
Merged: 7/17/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-9844/premium-account-bypass

📝 Commits (2)

  • a75c091 PM-9844 filter out option for copy TOTP if the user does not have premium
  • 16fd5eb move vals out of test class

📊 Changes

13 files changed (+120 additions, -36 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensions.kt (+10 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt (+9 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/util/CipherViewExtensions.kt (+5 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt (+20 -5)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchScreenTest.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModelTest.kt (+6 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensionsTest.kt (+4 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt (+9 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/util/CipherViewExtensionsTest.kt (+48 -28)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9844

📔 Objective

Currently from any of the Vault item listing areas (VaultScreen, Collection, and Search) you can copy a TOTP code without meeting one of the required precondition (a premium account or legacy Org. uses TOTP rule). This PR adds condition check for adding the "copy TOTP" overflow action only if the the user has premium or the CipherView being converted has a organizationUsesTotp value which is true

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3539 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 7/16/2024 **Status:** ✅ Merged **Merged:** 7/17/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-9844/premium-account-bypass` --- ### 📝 Commits (2) - [`a75c091`](https://github.com/bitwarden/android/commit/a75c0917919dcada9226425bfd4b979a0ae20b69) PM-9844 filter out option for copy TOTP if the user does not have premium - [`16fd5eb`](https://github.com/bitwarden/android/commit/16fd5ebed0559454e90c7bcabe82187ceb3e6da6) move vals out of test class ### 📊 Changes **13 files changed** (+120 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensions.kt` (+10 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt` (+9 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/util/CipherViewExtensions.kt` (+5 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt` (+20 -5) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchScreenTest.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModelTest.kt` (+6 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensionsTest.kt` (+4 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt` (+9 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/util/CipherViewExtensionsTest.kt` (+48 -28) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-9844 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective Currently from any of the Vault item listing areas (VaultScreen, Collection, and Search) you can copy a TOTP code without meeting one of the required precondition (a premium account or legacy Org. uses TOTP rule). This PR adds condition check for adding the "copy TOTP" overflow action only if the the user has premium or the CipherView being converted has a `organizationUsesTotp` value which is `true` ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 14:04:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#30260
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?