github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-19 12:47:49 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3419] [MERGED] Update to the latest Bitwarden SDK #30221

New Issue
Closed
opened 2026-04-18 14:02:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 14:02:45 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3419
Author: @david-livefront
Created: 7/8/2024
Status: ✅ Merged
Merged: 7/8/2024
Merged by: @david-livefront

Base: main ← Head: update-bitwarden-sdk

📝 Commits (1)

  • fc4c88d Update to the latest Bitwarden SDK

📊 Changes

24 files changed (+64 additions, -62 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSource.kt (+4 -4)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceImpl.kt (+5 -5)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/manager/AuthRequestManagerImpl.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/manager/model/CreateAuthRequestResult.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSource.kt (+6 -6)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt (+5 -5)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialAuthenticationUserInterfaceImpl.kt (+2 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialRegistrationUserInterfaceImpl.kt (+2 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManager.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/model/ExportVaultFormat.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceTest.kt (+5 -5)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/manager/AuthRequestManagerTest.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+6 -6)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceTest.kt (+5 -5)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerTest.kt (+3 -3)

...and 4 more files

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR update the app to use the latest version of the Bitwarden SDK.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3419 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 7/8/2024 **Status:** ✅ Merged **Merged:** 7/8/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `update-bitwarden-sdk` --- ### 📝 Commits (1) - [`fc4c88d`](https://github.com/bitwarden/android/commit/fc4c88d7fcb3bf5105dd4deae87a780543487ff5) Update to the latest Bitwarden SDK ### 📊 Changes **24 files changed** (+64 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSource.kt` (+4 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceImpl.kt` (+5 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/manager/AuthRequestManagerImpl.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/manager/model/CreateAuthRequestResult.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSource.kt` (+6 -6) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt` (+5 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialAuthenticationUserInterfaceImpl.kt` (+2 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialRegistrationUserInterfaceImpl.kt` (+2 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManager.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/model/ExportVaultFormat.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/sdk/AuthSdkSourceTest.kt` (+5 -5) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/manager/AuthRequestManagerTest.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+6 -6) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceTest.kt` (+5 -5) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerTest.kt` (+3 -3) _...and 4 more files_ </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR update the app to use the latest version of the Bitwarden SDK. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 14:02:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#30221