github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1632] [MERGED] Change Release workflow to allow releases from 'rc' and 'hotfix' branches #3017

New Issue
Closed
opened 2025-11-26 23:27:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:27:11 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1632
Author: @vgrassia
Created: 11/5/2021
Status: ✅ Merged
Merged: 11/8/2021
Merged by: @vgrassia

Base: master ← Head: fix-release-branch-strategy

📝 Commits (2)

  • 81e9798 Change release workflow to only allow releases from rc or hotfix branches
  • 57ddef0 Change out release branch for hotfix branch in build workflow

📊 Changes

2 files changed (+26 additions, -19 deletions)

View changed files

📝 .github/workflows/build.yml (+14 -11)
📝 .github/workflows/release.yml (+12 -8)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Changes our release workflow to allow releases from only rc and hotfix branches.

Code changes

  • release.yml: Adds step to the setup job to find the branch name and set it as an output for the job. Changes the rest of the workflow to use that new branch variable.
  • build.yml: Update logic for hotfix branch.

Before you submit

  • I have checked for workflow linting errors (required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1632 **Author:** [@vgrassia](https://github.com/vgrassia) **Created:** 11/5/2021 **Status:** ✅ Merged **Merged:** 11/8/2021 **Merged by:** [@vgrassia](https://github.com/vgrassia) **Base:** `master` ← **Head:** `fix-release-branch-strategy` --- ### 📝 Commits (2) - [`81e9798`](https://github.com/bitwarden/android/commit/81e9798a6d94cb8daf70abf9f68bacb243097f95) Change release workflow to only allow releases from rc or hotfix branches - [`57ddef0`](https://github.com/bitwarden/android/commit/57ddef09a6bc4eb34171aef33558e8909959f922) Change out release branch for hotfix branch in build workflow ### 📊 Changes **2 files changed** (+26 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+14 -11) 📝 `.github/workflows/release.yml` (+12 -8) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [X] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Changes our `release` workflow to allow releases from only `rc` and `hotfix` branches. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **release.yml:** Adds step to the `setup` job to find the branch name and set it as an output for the job. Changes the rest of the workflow to use that new branch variable. * **build.yml:** Update logic for `hotfix` branch. ## Before you submit - [X] I have checked for workflow **linting** errors (required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:27:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3017
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?