github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 20:24:33 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1621] [MERGED] Added account deletion feature on settings #3008

New Issue
Closed
opened 2025-11-26 23:27:05 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:27:05 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1621
Author: @fedemkr
Created: 10/29/2021
Status: ✅ Merged
Merged: 11/24/2021
Merged by: @fedemkr

Base: master ← Head: account-deletion-final

📝 Commits (4)

  • 730f1f8 Added account deletion feature on settings
  • 365ca25 Disabled using Microsoft.AppCenter.Crashes for FDroid
  • 515cfaf Merge branch 'master' into account-deletion-final
  • 0a3e317 Moved drawable on Android.csproj to be with the others

📊 Changes

22 files changed (+884 additions, -20 deletions)

View changed files

📝 src/Android/Android.csproj (+1 -0)
➕ src/Android/Resources/drawable/ic_warning.xml (+9 -0)
📝 src/App/Abstractions/IPasswordRepromptService.cs (+2 -0)
➕ src/App/Pages/Accounts/DeleteAccountPage.xaml (+56 -0)
➕ src/App/Pages/Accounts/DeleteAccountPage.xaml.cs (+33 -0)
➕ src/App/Pages/Accounts/DeleteAccountViewModel.cs (+84 -0)
📝 src/App/Pages/Settings/SettingsPage/SettingsPage.xaml.cs (+8 -3)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+2 -1)
📝 src/App/Resources/AppResources.Designer.cs (+30 -0)
📝 src/App/Resources/AppResources.resx (+15 -0)
📝 src/App/Services/MobilePasswordRepromptService.cs (+14 -14)
📝 src/App/Services/MobilePlatformUtilsService.cs (+7 -2)
📝 src/App/Styles/Android.xaml (+33 -0)
📝 src/App/Styles/Base.xaml (+7 -0)
📝 src/App/Styles/iOS.xaml (+38 -0)
📝 src/Core/Abstractions/IApiService.cs (+1 -0)
📝 src/Core/Abstractions/IPlatformUtilsService.cs (+1 -0)
➕ src/Core/Models/Request/DeleteAccountRequest.cs (+7 -0)
📝 src/Core/Services/ApiService.cs (+5 -0)
➕ src/iOS/Resources/Assets.xcassets/ic_warning.imageset/Contents.json (+528 -0)

...and 2 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add the possibility to delete the user account from the app

Code changes

  • SettingsPage.xaml.cs: Added navigation to Delete page
  • SettingsPageViewModel.cs: Added Delete Account item
  • MobilePasswordRepromptService and MobilePlatformUtilsService: Refactor to also return the password
  • ApiService: Added Delete account method
  • Styles/: Added button styles

Screenshots

Testing requirements

QA needs to make sure that after deleting the account, there are no traces on the server of it. Also try this with no internet connection or poor quality connection to check error handling.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1621 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 10/29/2021 **Status:** ✅ Merged **Merged:** 11/24/2021 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `account-deletion-final` --- ### 📝 Commits (4) - [`730f1f8`](https://github.com/bitwarden/android/commit/730f1f8af7768be9a6f837929c7b096bc023e1dd) Added account deletion feature on settings - [`365ca25`](https://github.com/bitwarden/android/commit/365ca2567eff290b5526b801a414427503a3b78d) Disabled using Microsoft.AppCenter.Crashes for FDroid - [`515cfaf`](https://github.com/bitwarden/android/commit/515cfafb2ffbda6284e8e8be68d0ecac8c60450d) Merge branch 'master' into account-deletion-final - [`0a3e317`](https://github.com/bitwarden/android/commit/0a3e3172d60ba863645dc3515c026a13e53a78df) Moved drawable on Android.csproj to be with the others ### 📊 Changes **22 files changed** (+884 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+1 -0) ➕ `src/Android/Resources/drawable/ic_warning.xml` (+9 -0) 📝 `src/App/Abstractions/IPasswordRepromptService.cs` (+2 -0) ➕ `src/App/Pages/Accounts/DeleteAccountPage.xaml` (+56 -0) ➕ `src/App/Pages/Accounts/DeleteAccountPage.xaml.cs` (+33 -0) ➕ `src/App/Pages/Accounts/DeleteAccountViewModel.cs` (+84 -0) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPage.xaml.cs` (+8 -3) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+2 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+30 -0) 📝 `src/App/Resources/AppResources.resx` (+15 -0) 📝 `src/App/Services/MobilePasswordRepromptService.cs` (+14 -14) 📝 `src/App/Services/MobilePlatformUtilsService.cs` (+7 -2) 📝 `src/App/Styles/Android.xaml` (+33 -0) 📝 `src/App/Styles/Base.xaml` (+7 -0) 📝 `src/App/Styles/iOS.xaml` (+38 -0) 📝 `src/Core/Abstractions/IApiService.cs` (+1 -0) 📝 `src/Core/Abstractions/IPlatformUtilsService.cs` (+1 -0) ➕ `src/Core/Models/Request/DeleteAccountRequest.cs` (+7 -0) 📝 `src/Core/Services/ApiService.cs` (+5 -0) ➕ `src/iOS/Resources/Assets.xcassets/ic_warning.imageset/Contents.json` (+528 -0) _...and 2 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add the possibility to delete the user account from the app ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **SettingsPage.xaml.cs:** Added navigation to Delete page * **SettingsPageViewModel.cs:** Added Delete Account item * **MobilePasswordRepromptService and MobilePlatformUtilsService:** Refactor to also return the _password_ * **ApiService:** Added Delete account method * **Styles/:** Added button styles ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> QA needs to make sure that after deleting the account, there are no traces on the server of it. Also try this with no internet connection or poor quality connection to check error handling. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [X] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:27:05 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3008
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?