github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-21 03:21:29 -05:00
Code Issues 1.5k Packages Projects Releases 125 Wiki Activity

[PR #3101] [MERGED] [PM-6655] Add username empty fallback on passkey #30033

New Issue
Closed
opened 2026-04-18 13:53:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:53:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3101
Author: @fedemkr
Created: 3/21/2024
Status: ✅ Merged
Merged: 3/21/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: vault/pm-6655/add-fallback-username-empty-passkey

📝 Commits (3)

  • f021a44 PM-6655 Added fallback "Unknown account" to passkey username and moved it so it can be shared with Android
  • 5021dfd PM-6655 Improved code lines formatting
  • 5e9e3db Merge branch 'feature/maui-migration-passkeys' into vault/pm-6655/add-fallback-username-empty-passkey

📊 Changes

5 files changed (+31 additions, -18 deletions)

View changed files

📝 src/Core/Models/View/LoginView.cs (+14 -4)
📝 src/Core/Resources/Localization/AppResources.Designer.cs (+9 -0)
📝 src/Core/Resources/Localization/AppResources.resx (+3 -0)
📝 src/Core/Utilities/StringExtensions.cs (+3 -2)
📝 src/iOS.Core/Utilities/ASHelpers.cs (+2 -12)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add username empty fallback on passkey

Code changes

Added the fallback value to the username and moved a bit the logic so it can be shared on Android as well.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3101 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/21/2024 **Status:** ✅ Merged **Merged:** 3/21/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `vault/pm-6655/add-fallback-username-empty-passkey` --- ### 📝 Commits (3) - [`f021a44`](https://github.com/bitwarden/android/commit/f021a44f7dc0def446a5587c1e723c4064f84d3b) PM-6655 Added fallback "Unknown account" to passkey username and moved it so it can be shared with Android - [`5021dfd`](https://github.com/bitwarden/android/commit/5021dfdddfd24dc20e4553955a4ea96ec1247369) PM-6655 Improved code lines formatting - [`5e9e3db`](https://github.com/bitwarden/android/commit/5e9e3db8050bce7ac15d08d6e9be2d48ba4a4d2f) Merge branch 'feature/maui-migration-passkeys' into vault/pm-6655/add-fallback-username-empty-passkey ### 📊 Changes **5 files changed** (+31 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Models/View/LoginView.cs` (+14 -4) 📝 `src/Core/Resources/Localization/AppResources.Designer.cs` (+9 -0) 📝 `src/Core/Resources/Localization/AppResources.resx` (+3 -0) 📝 `src/Core/Utilities/StringExtensions.cs` (+3 -2) 📝 `src/iOS.Core/Utilities/ASHelpers.cs` (+2 -12) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add username empty fallback on passkey ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Added the fallback value to the username and moved a bit the logic so it can be shared on Android as well. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:53:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#30033
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?