github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-18 14:19:36 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #3021] [MERGED] Optimize assertion network calls #29975

New Issue
Closed
opened 2026-04-18 13:50:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:50:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3021
Author: @coroiu
Created: 2/22/2024
Status: ✅ Merged
Merged: 2/22/2024
Merged by: @coroiu

Base: feature/maui-migration-passkeys ← Head: feature/optimize-assertions

📝 Commits (1)

  • 227fbf7 feat: optimize assertion network calls

📊 Changes

2 files changed (+112 additions, -68 deletions)

View changed files

📝 src/Core/Services/Fido2AuthenticatorService.cs (+79 -45)
📝 test/Core.Test/Services/Fido2AuthenticatorGetAssertionTests.cs (+33 -23)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The server only needs to be updated if we have changed the counter. New passkeys that leave their counters at zero can therefore skip this step.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3021 **Author:** [@coroiu](https://github.com/coroiu) **Created:** 2/22/2024 **Status:** ✅ Merged **Merged:** 2/22/2024 **Merged by:** [@coroiu](https://github.com/coroiu) **Base:** `feature/maui-migration-passkeys` ← **Head:** `feature/optimize-assertions` --- ### 📝 Commits (1) - [`227fbf7`](https://github.com/bitwarden/android/commit/227fbf7dcd6bff50b7a487a622b94c771e49d5af) feat: optimize assertion network calls ### 📊 Changes **2 files changed** (+112 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/Fido2AuthenticatorService.cs` (+79 -45) 📝 `test/Core.Test/Services/Fido2AuthenticatorGetAssertionTests.cs` (+33 -23) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective The server only needs to be updated if we have changed the counter. New passkeys that leave their counters at zero can therefore skip this step. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:50:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#29975
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?