github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-09 16:21:19 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #1603] [MERGED] Fix HTML labels colors issue (#1516) #2997

New Issue
Closed
opened 2025-11-26 23:26:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:26:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1603
Author: @Federico-Maccaroni
Created: 10/22/2021
Status: ✅ Merged
Merged: 10/25/2021
Merged by: @Federico-Maccaroni

Base: master ← Head: fix-password-generated-html-colors

📝 Commits (1)

📊 Changes

5 files changed (+12 additions, -8 deletions)

View changed files

📝 src/App/Pages/Generator/GeneratorHistoryPage.xaml (+1 -2)
📝 src/App/Pages/Generator/GeneratorPage.xaml (+1 -2)
📝 src/App/Pages/Vault/PasswordHistoryPage.xaml (+1 -2)
📝 src/App/Pages/Vault/ViewPage.xaml (+1 -2)
📝 src/App/Styles/Base.xaml (+8 -0)

📄 Description

Fixed HTMl labels colors issue that was not taking the html style color correctly.

This was because Xamarin Forms expect that the Label color be the Default one and the Base styles were overriding that.

So I created a new style text-html that sets the TextColor to Default and the TextType to Html.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1603 **Author:** [@Federico-Maccaroni](https://github.com/Federico-Maccaroni) **Created:** 10/22/2021 **Status:** ✅ Merged **Merged:** 10/25/2021 **Merged by:** [@Federico-Maccaroni](https://github.com/Federico-Maccaroni) **Base:** `master` ← **Head:** `fix-password-generated-html-colors` --- ### 📝 Commits (1) - [`aa6b7ea`](https://github.com/bitwarden/android/commit/aa6b7ea7450c5212f97acea9e3126eec43680e3b) Fix html labels colors issue (#1516) ### 📊 Changes **5 files changed** (+12 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Generator/GeneratorHistoryPage.xaml` (+1 -2) 📝 `src/App/Pages/Generator/GeneratorPage.xaml` (+1 -2) 📝 `src/App/Pages/Vault/PasswordHistoryPage.xaml` (+1 -2) 📝 `src/App/Pages/Vault/ViewPage.xaml` (+1 -2) 📝 `src/App/Styles/Base.xaml` (+8 -0) </details> ### 📄 Description Fixed HTMl labels colors issue that was not taking the html style color correctly. This was because [Xamarin Forms expect](https://github.com/xamarin/Xamarin.Forms/blob/cd675ae32b/Xamarin.Forms.Platform.iOS/Renderers/LabelRenderer.cs#L569) that the Label color be the Default one and the Base styles were overriding that. So I created a new style `text-html` that sets the TextColor to Default and the TextType to Html. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:26:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2997
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?