github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 05:02:48 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1601] [MERGED] Fixed long secure notes edition scrolling when focused issue (#1257) #2995

New Issue
Closed
opened 2025-11-26 23:26:54 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:26:54 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1601
Author: @Federico-Maccaroni
Created: 10/22/2021
Status: ✅ Merged
Merged: 10/25/2021
Merged by: @Federico-Maccaroni

Base: master ← Head: fix-scroll-secure-notes-final

📝 Commits (4)

  • 6ad2a01 Fixed long secure notes edition scrolling when focused issue (#1257)
  • c47107c Merge branch 'master' into fix-scroll-secure-notes-final
  • 72ee103 Improved fix long secure notes edition scrolling when focused issue to not use a new editor custom renderer but an effect (#1257)
  • 1e721d0 Fixed long editor, on text and notes on send when scrolling when focused issue (#1257)

📊 Changes

7 files changed (+131 additions, -4 deletions)

View changed files

📝 src/App/App.csproj (+4 -0)
➕ src/App/Behaviors/EditorPreventAutoBottomScrollingOnFocusedBehavior.cs (+43 -0)
➕ src/App/Effects/ScrollEnabledEffect.cs (+25 -0)
📝 src/App/Pages/Send/SendAddEditPage.xaml (+20 -2)
📝 src/App/Pages/Vault/AddEditPage.xaml (+12 -2)
➕ src/iOS.Core/Effects/ScrollEnabledEffect.cs (+25 -0)
📝 src/iOS.Core/iOS.Core.csproj (+2 -0)

📄 Description

When editing Secure Notes and the field was long and the user tapped, the scroll will go to the bottom and not the place where the user tapped or selected. So fixed this so that scrolling doesn't happen and the scroll remains at the cursor of the notes field.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1601 **Author:** [@Federico-Maccaroni](https://github.com/Federico-Maccaroni) **Created:** 10/22/2021 **Status:** ✅ Merged **Merged:** 10/25/2021 **Merged by:** [@Federico-Maccaroni](https://github.com/Federico-Maccaroni) **Base:** `master` ← **Head:** `fix-scroll-secure-notes-final` --- ### 📝 Commits (4) - [`6ad2a01`](https://github.com/bitwarden/android/commit/6ad2a0185bd0fe7f83b30fb6170e472c04773a46) Fixed long secure notes edition scrolling when focused issue (#1257) - [`c47107c`](https://github.com/bitwarden/android/commit/c47107c683e2f784839a515f94de70dc2e25e8e2) Merge branch 'master' into fix-scroll-secure-notes-final - [`72ee103`](https://github.com/bitwarden/android/commit/72ee103c3f42818e678763226b05fe17a216f7c2) Improved fix long secure notes edition scrolling when focused issue to not use a new editor custom renderer but an effect (#1257) - [`1e721d0`](https://github.com/bitwarden/android/commit/1e721d006d01f2ed3e0a22725f55e696fba8d8d8) Fixed long editor, on text and notes on send when scrolling when focused issue (#1257) ### 📊 Changes **7 files changed** (+131 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.csproj` (+4 -0) ➕ `src/App/Behaviors/EditorPreventAutoBottomScrollingOnFocusedBehavior.cs` (+43 -0) ➕ `src/App/Effects/ScrollEnabledEffect.cs` (+25 -0) 📝 `src/App/Pages/Send/SendAddEditPage.xaml` (+20 -2) 📝 `src/App/Pages/Vault/AddEditPage.xaml` (+12 -2) ➕ `src/iOS.Core/Effects/ScrollEnabledEffect.cs` (+25 -0) 📝 `src/iOS.Core/iOS.Core.csproj` (+2 -0) </details> ### 📄 Description When editing Secure Notes and the field was long and the user tapped, the scroll will go to the bottom and not the place where the user tapped or selected. So fixed this so that scrolling doesn't happen and the scroll remains at the cursor of the notes field. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:26:54 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2995
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?