github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2981] [MERGED] [PM-5906] Fix for incorrect Send MaxAccess white text color on label when using light theme on iOS #29938

New Issue
Closed
opened 2026-04-18 13:48:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:48:27 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2981
Author: @dinisvieira
Created: 2/6/2024
Status: ✅ Merged
Merged: 2/7/2024
Merged by: @dinisvieira

Base: feature/maui-migration ← Head: feature/PM-5906-incorrect-text-color-light-theme

📝 Commits (2)

  • 51eccd3 PM-5906 workaround for incorrect textcolor when programmatically changing text on Entry
  • 58789f9 Update src/Core/Pages/Send/SendAddEditPage.xaml.cs

📊 Changes

1 file changed (+11 additions, -1 deletions)

View changed files

📝 src/Core/Pages/Send/SendAddEditPage.xaml.cs (+11 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix for incorrect Send MaxAccess white text color on label when using light theme on iOS.
This fix is a workaround for the MAUI Issue https://github.com/dotnet/maui/pull/20100

Code changes

  • SendAddEditPage.xaml.cs: Set the TextColor to null and back to the correct color whenever we try to programatically change the entry text. Doing this avoids the bug.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2981 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 2/6/2024 **Status:** ✅ Merged **Merged:** 2/7/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `feature/maui-migration` ← **Head:** `feature/PM-5906-incorrect-text-color-light-theme` --- ### 📝 Commits (2) - [`51eccd3`](https://github.com/bitwarden/android/commit/51eccd3fd722d0edf8dbec922ebea05e2beb6c0d) PM-5906 workaround for incorrect textcolor when programmatically changing text on Entry - [`58789f9`](https://github.com/bitwarden/android/commit/58789f9f6f15101df42f9d1a6e67caef4a7be2ea) Update src/Core/Pages/Send/SendAddEditPage.xaml.cs ### 📊 Changes **1 file changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Pages/Send/SendAddEditPage.xaml.cs` (+11 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fix for incorrect Send MaxAccess white text color on label when using light theme on iOS. This fix is a workaround for the MAUI Issue https://github.com/dotnet/maui/pull/20100 ## Code changes * **SendAddEditPage.xaml.cs:** Set the TextColor to null and back to the correct color whenever we try to programatically change the entry text. Doing this avoids the bug. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:48:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#29938