github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1592] [MERGED] Turn off autofill compatibility mode on the latest Firefox and Beta #2987

New Issue
Closed
opened 2025-11-26 23:26:48 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:26:48 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1592
Author: @makotokato
Created: 10/18/2021
Status: ✅ Merged
Merged: 10/28/2021
Merged by: @mpbw2

Base: master ← Head: compatmode

📝 Commits (1)

  • b5f1c4f Turn off autofill compatibility mode on the latest Firefox and Firefox beta.

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/Android/Resources/xml/autofillservice.xml (+2 -2)

📄 Description

Firefox (after Fenix) has native support of Android's autofill framework. So it is unnecessary to turn on autofill compatibility mode for autofill service. But Bitwarden still seems to enable it for Firefox.

This compatibility mode walks through the all virtual nodes using accessibility API, so application supports both (autofill native support and accessibility API), it has multiple virtual nodes for same element. And this mode also cause performance issue as browser since accessing accessibility nodes is too slow.

Also, this mode causes another bug. This mode steals focus by accessibility API. See https://bugzilla.mozilla.org/show_bug.cgi?id=1715549#c6 for more details. As long as debugging Firefox Nightly, Bitwarden seems not to turn on this mode.

So I would like to request to turn off this mode on the latest Firefox. (This version code for this fix is 93.1.0 and 94 beta 3). I believe that this fix resolves a lot of strange bugs on Bitwarden + Firefox.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1592 **Author:** [@makotokato](https://github.com/makotokato) **Created:** 10/18/2021 **Status:** ✅ Merged **Merged:** 10/28/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `compatmode` --- ### 📝 Commits (1) - [`b5f1c4f`](https://github.com/bitwarden/android/commit/b5f1c4f82999ae243147da9eb68ada2136f76ce5) Turn off autofill compatibility mode on the latest Firefox and Firefox beta. ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Resources/xml/autofillservice.xml` (+2 -2) </details> ### 📄 Description Firefox (after Fenix) has native support of Android's autofill framework. So it is unnecessary to turn on autofill compatibility mode for autofill service. But Bitwarden still seems to enable it for Firefox. This compatibility mode walks through the all virtual nodes using accessibility API, so application supports both (autofill native support and accessibility API), it has multiple virtual nodes for same element. And this mode also cause performance issue as browser since accessing accessibility nodes is too slow. Also, this mode causes another bug. This mode steals focus by accessibility API. See https://bugzilla.mozilla.org/show_bug.cgi?id=1715549#c6 for more details. As long as debugging Firefox Nightly, Bitwarden seems not to turn on this mode. So I would like to request to turn off this mode on the latest Firefox. (This version code for this fix is 93.1.0 and 94 beta 3). I believe that this fix resolves a lot of strange bugs on Bitwarden + Firefox. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:26:48 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2987
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?