github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2869] [MERGED] [PM-4837] Hide TOTP seed copy button when Can view, except password permission set #29863

New Issue
Closed
opened 2026-04-18 13:45:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:45:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2869
Author: @mpbw2
Created: 11/15/2023
Status: ✅ Merged
Merged: 12/11/2023
Merged by: @mpbw2

Base: master ← Head: bugfix/totpseed-visibility

📝 Commits (9)

  • adce58c Hide TOTP seed copy button when Can view, except password permission set
  • f63d319 additional check
  • 0234ffc removal of null check
  • 614a37c Merge branch 'master' into bugfix/totpseed-visibility
  • 2e1a2b2 Merge branch 'master' into bugfix/totpseed-visibility
  • 81a3a5d Merge remote-tracking branch 'origin/bugfix/totpseed-visibility' into bugfix/totpseed-visibility
  • 6e5d127 Merge branch 'master' into bugfix/totpseed-visibility
  • a134cf5 Merge branch 'master' into bugfix/totpseed-visibility
  • 973362e Merge branch 'master' into bugfix/totpseed-visibility

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

📝 src/App/Pages/Vault/CipherAddEditPage.xaml (+1 -1)
📝 src/App/Pages/Vault/CipherAddEditPageViewModel.cs (+1 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Hide the copy button on the TOTP seed field when editing an item where Can view, except password permission is set to prevent user from obtaining seed value

Code changes

  • CipherAddEditPage.xaml: Use Cipher.ViewPassword property to drive copy icon visibility

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2869 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 11/15/2023 **Status:** ✅ Merged **Merged:** 12/11/2023 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix/totpseed-visibility` --- ### 📝 Commits (9) - [`adce58c`](https://github.com/bitwarden/android/commit/adce58c0e62a17e60ba77f3ee25e3b0fa01517ff) Hide TOTP seed copy button when Can view, except password permission set - [`f63d319`](https://github.com/bitwarden/android/commit/f63d319b3a0caaae931133bcd808b15556587446) additional check - [`0234ffc`](https://github.com/bitwarden/android/commit/0234ffc86adcc0460946cc8f0d27e35585e95a06) removal of null check - [`614a37c`](https://github.com/bitwarden/android/commit/614a37c60e44e1fa4944d41702db2b2a93e034ad) Merge branch 'master' into bugfix/totpseed-visibility - [`2e1a2b2`](https://github.com/bitwarden/android/commit/2e1a2b29164fa43e2488c6ead7a593034a3531ce) Merge branch 'master' into bugfix/totpseed-visibility - [`81a3a5d`](https://github.com/bitwarden/android/commit/81a3a5d1d3a56fe5f5aa50067bd2ee1988021202) Merge remote-tracking branch 'origin/bugfix/totpseed-visibility' into bugfix/totpseed-visibility - [`6e5d127`](https://github.com/bitwarden/android/commit/6e5d1273ee73d802f8d42aeb8e8f52254b666656) Merge branch 'master' into bugfix/totpseed-visibility - [`a134cf5`](https://github.com/bitwarden/android/commit/a134cf5d974980859b1ac7628825a4b7b2044496) Merge branch 'master' into bugfix/totpseed-visibility - [`973362e`](https://github.com/bitwarden/android/commit/973362e61b6b00565ff6f45bf918673a81bc21c8) Merge branch 'master' into bugfix/totpseed-visibility ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/CipherAddEditPage.xaml` (+1 -1) 📝 `src/App/Pages/Vault/CipherAddEditPageViewModel.cs` (+1 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Hide the copy button on the TOTP seed field when editing an item where `Can view, except password` permission is set to prevent user from obtaining seed value ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CipherAddEditPage.xaml:** Use `Cipher.ViewPassword` property to drive copy icon visibility ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:45:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#29863
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?