github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2747] [MERGED] [PM-3393] Excessive Invalid Biometric unlock attempts should automatically log out TDE users #29793

New Issue
Closed
opened 2026-04-18 13:42:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:42:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2747
Author: @andrebispo5
Created: 9/7/2023
Status: ✅ Merged
Merged: 9/19/2023
Merged by: @andrebispo5

Base: master ← Head: auth/pm-3393/biometric-exceed

📝 Commits (9)

  • eb7ef90 [PM-3393] Log user out on biometric exceed attempts
  • e2c4103 [PM-3393] Move duplicated code to AppHelpers
  • 1112ee4 [PM-3393] Update copy on new pop up
  • 8531cc5 [PM-3393] PR fixes
  • bec369e [PM-3393] Moved VaultTimeoutService to LazyResolve.
  • bd8a4ea [PM-3382] Change IVaultTimeoutService for messaging
  • e8a760f [PM-3393] Fix labels
  • 641c598 [PM-3393] Use default values.
  • f4148d4 Merge branch 'master' into auth/pm-3393/biometric-exceed

📊 Changes

7 files changed (+41 additions, -6 deletions)

View changed files

📝 src/App/Pages/Accounts/LockPageViewModel.cs (+2 -1)
📝 src/App/Resources/AppResources.Designer.cs (+19 -1)
📝 src/App/Resources/AppResources.resx (+6 -0)
📝 src/App/Services/MobilePlatformUtilsService.cs (+9 -2)
📝 src/App/Utilities/AppHelpers.cs (+1 -0)
📝 src/Core/Abstractions/IPlatformUtilsService.cs (+1 -1)
📝 src/iOS.Core/Controllers/BaseLockPasswordViewController.cs (+3 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

When the user has no master password or pin and exceeds the biometric login attempts, the app should logged out.

Code changes

Add action to IsBiometricIntegrityValidAsync to invoke when the TooManyAttempts is triggered.
Add to AppHelpers a method to check if the user doesn't have other login methods available, show a warning message and logout.

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2747 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 9/7/2023 **Status:** ✅ Merged **Merged:** 9/19/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `auth/pm-3393/biometric-exceed` --- ### 📝 Commits (9) - [`eb7ef90`](https://github.com/bitwarden/android/commit/eb7ef907590cdb210315a5cc724574cf1de675d4) [PM-3393] Log user out on biometric exceed attempts - [`e2c4103`](https://github.com/bitwarden/android/commit/e2c41037523644ade3c7a592eb2ac183539aa203) [PM-3393] Move duplicated code to AppHelpers - [`1112ee4`](https://github.com/bitwarden/android/commit/1112ee414d2d74675a2d7e46e967ceef07f2d9e3) [PM-3393] Update copy on new pop up - [`8531cc5`](https://github.com/bitwarden/android/commit/8531cc5081910f91d2fd30627e5c872d7a4c59ac) [PM-3393] PR fixes - [`bec369e`](https://github.com/bitwarden/android/commit/bec369ed92f8605ca23e7967c44558bb5f3397f6) [PM-3393] Moved VaultTimeoutService to LazyResolve. - [`bd8a4ea`](https://github.com/bitwarden/android/commit/bd8a4ea382a0603ea962da2042759173da974d76) [PM-3382] Change IVaultTimeoutService for messaging - [`e8a760f`](https://github.com/bitwarden/android/commit/e8a760fdd7f4e4eb8ef16947f0c1c337459e00cb) [PM-3393] Fix labels - [`641c598`](https://github.com/bitwarden/android/commit/641c598122c65258aaa113ff41bd843a9d1e45c1) [PM-3393] Use default values. - [`f4148d4`](https://github.com/bitwarden/android/commit/f4148d4cd248fc7fc11524d12656cde1659b770f) Merge branch 'master' into auth/pm-3393/biometric-exceed ### 📊 Changes **7 files changed** (+41 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+2 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+19 -1) 📝 `src/App/Resources/AppResources.resx` (+6 -0) 📝 `src/App/Services/MobilePlatformUtilsService.cs` (+9 -2) 📝 `src/App/Utilities/AppHelpers.cs` (+1 -0) 📝 `src/Core/Abstractions/IPlatformUtilsService.cs` (+1 -1) 📝 `src/iOS.Core/Controllers/BaseLockPasswordViewController.cs` (+3 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> When the user has no master password or pin and exceeds the biometric login attempts, the app should logged out. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Add action to `IsBiometricIntegrityValidAsync` to invoke when the TooManyAttempts is triggered. Add to `AppHelpers` a method to check if the user doesn't have other login methods available, show a warning message and logout. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:42:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#29793
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?