[PR #1580] [MERGED] fix for Captcha crashing on account creation #2977

Closed
opened 2025-11-26 23:26:40 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1580
Author: @jlf0dev
Created: 10/14/2021
Status: Merged
Merged: 10/14/2021
Merged by: @jlf0dev

Base: masterHead: bug/captcha-account-creation


📝 Commits (1)

  • 722147b fix for Captcha crashing on account creation

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 src/App/Pages/CaptchaProtectedViewModel.cs (+6 -1)

📄 Description

Overview

Bitwarden was crashing when a Captcha was requested on account creation because we had no loaded URLs in our EnvironmentService. This fix checks our GetWebVaultUrl call and returns our default URL if null.

This fix will be picked to rc

Closes #1574


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1580 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 10/14/2021 **Status:** ✅ Merged **Merged:** 10/14/2021 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `bug/captcha-account-creation` --- ### 📝 Commits (1) - [`722147b`](https://github.com/bitwarden/android/commit/722147b1f074bea7b350eccbe67462aaf1f2bb2a) fix for Captcha crashing on account creation ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/CaptchaProtectedViewModel.cs` (+6 -1) </details> ### 📄 Description # Overview Bitwarden was crashing when a Captcha was requested on account creation because we had no loaded URLs in our `EnvironmentService`. This fix checks our `GetWebVaultUrl` call and returns our default URL if null. This fix will be picked to `rc` Closes #1574 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:26:40 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2977