github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2657] [MERGED] [PM-3298] Updated region selector naming #29720

New Issue
Closed
opened 2026-04-18 13:38:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:38:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2657
Author: @fedemkr
Created: 8/3/2023
Status: ✅ Merged
Merged: 8/4/2023
Merged by: @fedemkr

Base: master ← Head: vault/pm-3298/update-region-selector

📝 Commits (2)

  • eacf8a2 PM-3298 Updated region selector to be logging in on and also its options
  • 9f03eac Merge branch 'master' into vault/pm-3298/update-region-selector

📊 Changes

3 files changed (+24 additions, -14 deletions)

View changed files

📝 src/App/Pages/Accounts/HomePageViewModel.cs (+11 -13)
📝 src/App/Resources/AppResources.Designer.cs (+10 -1)
📝 src/App/Resources/AppResources.resx (+3 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Update region selector naming

Code changes

  • HomePageViewModel: Changed "Region" and "Data Region" for "Logging in on" and also changed the "US"/"EU" options for more specific naming.

Screenshots

Home view Android

Home view Android

Logging in on picker Android

Logging in on picker Android

Home view iOS

Home view iOS

Logging in on picker iOS

Logging in on picker iOS

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2657 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 8/3/2023 **Status:** ✅ Merged **Merged:** 8/4/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `vault/pm-3298/update-region-selector` --- ### 📝 Commits (2) - [`eacf8a2`](https://github.com/bitwarden/android/commit/eacf8a2491e34dafbbb0c082e99bbde1803b7701) PM-3298 Updated region selector to be logging in on and also its options - [`9f03eac`](https://github.com/bitwarden/android/commit/9f03eaca7e4e8f53a2d59a7d6cb35f4fea5eb4c4) Merge branch 'master' into vault/pm-3298/update-region-selector ### 📊 Changes **3 files changed** (+24 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/HomePageViewModel.cs` (+11 -13) 📝 `src/App/Resources/AppResources.Designer.cs` (+10 -1) 📝 `src/App/Resources/AppResources.resx` (+3 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Update region selector naming ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **HomePageViewModel:** Changed "Region" and "Data Region" for "Logging in on" and also changed the "US"/"EU" options for more specific naming. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ### Home view Android <img width="314" alt="Home view Android" src="https://github.com/bitwarden/mobile/assets/15682323/09f5bd01-6e04-4cc9-bb40-e00a76c68ae8"> ### Logging in on picker Android <img width="314" alt="Logging in on picker Android" src="https://github.com/bitwarden/mobile/assets/15682323/467d8c2b-818e-4545-ad10-84b46ddd82a8"> ### Home view iOS <img width="314" alt="Home view iOS" src="https://github.com/bitwarden/mobile/assets/15682323/8aaaeb5d-5411-4efe-a2ab-18d60c80bb0a"> ### Logging in on picker iOS <img width="314" alt="Logging in on picker iOS" src="https://github.com/bitwarden/mobile/assets/15682323/69f1a000-573d-490f-a942-523ca770a764"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:38:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#29720
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?