github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2618] [MERGED] [PM-3018] Catch additional exception types when validating intents #29693

New Issue
Closed
opened 2026-04-18 13:37:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:37:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2618
Author: @mpbw2
Created: 7/13/2023
Status: ✅ Merged
Merged: 7/17/2023
Merged by: @mpbw2

Base: master ← Head: bugfix/intent-validation

📝 Commits (1)

  • e87ce65 Catch additional exception types when validating intents

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 src/Android/Utilities/IntentExtensions.cs (+7 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR fixes an additional app crash during intent validation if a bad actor is trying to pass a custom class extra (reported in hackerone)

Code changes

  • IntentExtensions.cs: add catches for ClassNotFoundException and RuntimeException in Validate

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2618 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 7/13/2023 **Status:** ✅ Merged **Merged:** 7/17/2023 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix/intent-validation` --- ### 📝 Commits (1) - [`e87ce65`](https://github.com/bitwarden/android/commit/e87ce659ac95efac3f4417b8b73b0bbf8e9bd062) Catch additional exception types when validating intents ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Utilities/IntentExtensions.cs` (+7 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> This PR fixes an additional app crash during intent validation if a bad actor is trying to pass a custom class extra (reported in hackerone) ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **IntentExtensions.cs:** add catches for `ClassNotFoundException` and `RuntimeException` in `Validate` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:37:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#29693
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?