github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1569] [MERGED] Hide label if no subtitle for Cipher #2969

New Issue
Closed
opened 2025-11-26 23:26:34 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:26:34 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1569
Author: @jlf0dev
Created: 10/8/2021
Status: ✅ Merged
Merged: 10/8/2021
Merged by: @jlf0dev

Base: master ← Head: bug/android-icons-misaligned

📝 Commits (2)

  • 1c28ffc Hide label if no subtitle for Cipher
  • c968ecb Merge branch 'master' into bug/android-icons-misaligned

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 src/App/Controls/CipherViewCell/CipherViewCell.xaml (+4 -1)

📄 Description

Android titles were misaligned for Ciphers when there was no subtitle. This was due to the subtitle taking up space even when the string was empty.

This fix checks if the subtitle has content, and if not sets the IsVisible property to false.
Closes #1160

Screen Shot 2021-10-07 at 5 47 33 PM Screen Shot 2021-10-07 at 5 45 03 PM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1569 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 10/8/2021 **Status:** ✅ Merged **Merged:** 10/8/2021 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `bug/android-icons-misaligned` --- ### 📝 Commits (2) - [`1c28ffc`](https://github.com/bitwarden/android/commit/1c28ffc4507ae627526be6a0158f0ab045ab059f) Hide label if no subtitle for Cipher - [`c968ecb`](https://github.com/bitwarden/android/commit/c968ecb61833cfc2bcb041d4a110cb9446affab4) Merge branch 'master' into bug/android-icons-misaligned ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/CipherViewCell/CipherViewCell.xaml` (+4 -1) </details> ### 📄 Description Android titles were misaligned for Ciphers when there was no subtitle. This was due to the subtitle taking up space even when the string was empty. This fix checks if the subtitle has content, and if not sets the `IsVisible` property to false. Closes #1160 <img width="416" alt="Screen Shot 2021-10-07 at 5 47 33 PM" src="https://user-images.githubusercontent.com/24985544/136468058-c2dcadbe-93ec-4c3c-86d2-23caaff73cef.png"> <img width="416" alt="Screen Shot 2021-10-07 at 5 45 03 PM" src="https://user-images.githubusercontent.com/24985544/136467901-e1ad233a-4eec-4ba1-92a2-9522358a71b5.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:26:34 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2969
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?