github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2580] [MERGED] [PM-2691] Adding AutomationIDs for Vault Page sections #29669

New Issue
Closed
opened 2026-04-18 13:36:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:36:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2580
Author: @ifernandezdiaz
Created: 6/22/2023
Status: ✅ Merged
Merged: 6/29/2023
Merged by: @ifernandezdiaz

Base: master ← Head: PM-2691/automationIDs-for-VaultPage-elements

📝 Commits (10+)

  • ffb43fc Adding IDs for Vault Page sections
  • 727fe08 Removing extra spaces
  • 509da8c Adding Matt's comments
  • 568822b Fixing Filters Id bug
  • 037a5b5 Merge branch 'PM-2691/automationIDs-for-VaultPage-elements' of github.com:bitwarden/mobile into PM-2691/automationIDs-for-VaultPage-elements
  • d8f4fa6 Adding Fede's suggestions
  • 07f0336 Fixing Settings Ids issues
  • 05b081e Fixing AutomationIds issues with RecyclerViews + implementing AutomationId helper class
  • 4f8c674 Adding Fede's suggestion
  • f505b21 Merge branch 'master' into PM-2691/automationIDs-for-VaultPage-elements

📊 Changes

14 files changed (+178 additions, -30 deletions)

View changed files

📝 src/Android/Android.csproj (+1 -0)
➕ src/Android/Renderers/CustomLabelRenderer.cs (+31 -0)
📝 src/App/App.csproj (+2 -0)
➕ src/App/Controls/CustomLabel.cs (+13 -0)
📝 src/App/Pages/Settings/SettingsPage/SettingsPage.xaml (+5 -6)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageListItem.cs (+18 -12)
📝 src/App/Pages/Vault/CipherDetailsPage.xaml (+4 -3)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml (+13 -7)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageHeaderListItem.cs (+10 -1)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageListGroup.cs (+2 -0)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageListItem.cs (+34 -0)
➕ src/App/Utilities/Automation/AutomationIdsHelper.cs (+23 -0)
➕ src/App/Utilities/Automation/SuffixType.cs (+13 -0)
📝 src/iOS.Core/Renderers/CustomLabelRenderer.cs (+9 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests

Code changes

  • GroupingsPage.xaml: Adding AutomationID label to filters and headers
  • GroupingsPageHeaderListItem.cs: Adding AutomationId variable.
  • GroupingsPageHeaderListGroup.cs: Adding AutomationId variable.
  • GroupingsPageListItem.cs: Adding AutomationId variable.

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2580 **Author:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Created:** 6/22/2023 **Status:** ✅ Merged **Merged:** 6/29/2023 **Merged by:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Base:** `master` ← **Head:** `PM-2691/automationIDs-for-VaultPage-elements` --- ### 📝 Commits (10+) - [`ffb43fc`](https://github.com/bitwarden/android/commit/ffb43fc27ad58b8edf6f48e6291720040a3dde12) Adding IDs for Vault Page sections - [`727fe08`](https://github.com/bitwarden/android/commit/727fe081c679f02a6cfbd61695bae36ecb5b4ea9) Removing extra spaces - [`509da8c`](https://github.com/bitwarden/android/commit/509da8ca1efefb4cfc34bfc88aa903f43b8a8775) Adding Matt's comments - [`568822b`](https://github.com/bitwarden/android/commit/568822b5a9f5e14363646dbd24a81fdfd503ea80) Fixing Filters Id bug - [`037a5b5`](https://github.com/bitwarden/android/commit/037a5b5cd42c4d48917804565c5cdf6f12a28a8c) Merge branch 'PM-2691/automationIDs-for-VaultPage-elements' of github.com:bitwarden/mobile into PM-2691/automationIDs-for-VaultPage-elements - [`d8f4fa6`](https://github.com/bitwarden/android/commit/d8f4fa6671389e4e45910f6ce04a9a9a64d3cb2d) Adding Fede's suggestions - [`07f0336`](https://github.com/bitwarden/android/commit/07f0336aa4648dda9890d53b3890cc8d3edfcc52) Fixing Settings Ids issues - [`05b081e`](https://github.com/bitwarden/android/commit/05b081ef74ebb8b17638c2cea4aaf3f5cfa0f6f3) Fixing AutomationIds issues with RecyclerViews + implementing AutomationId helper class - [`4f8c674`](https://github.com/bitwarden/android/commit/4f8c674a6648cf91f0ee4994eb78ef906e3a0c28) Adding Fede's suggestion - [`f505b21`](https://github.com/bitwarden/android/commit/f505b21f9a72500717eac024dca9464613548865) Merge branch 'master' into PM-2691/automationIDs-for-VaultPage-elements ### 📊 Changes **14 files changed** (+178 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+1 -0) ➕ `src/Android/Renderers/CustomLabelRenderer.cs` (+31 -0) 📝 `src/App/App.csproj` (+2 -0) ➕ `src/App/Controls/CustomLabel.cs` (+13 -0) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPage.xaml` (+5 -6) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageListItem.cs` (+18 -12) 📝 `src/App/Pages/Vault/CipherDetailsPage.xaml` (+4 -3) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml` (+13 -7) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageHeaderListItem.cs` (+10 -1) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageListGroup.cs` (+2 -0) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageListItem.cs` (+34 -0) ➕ `src/App/Utilities/Automation/AutomationIdsHelper.cs` (+23 -0) ➕ `src/App/Utilities/Automation/SuffixType.cs` (+13 -0) 📝 `src/iOS.Core/Renderers/CustomLabelRenderer.cs` (+9 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests ## Code changes * **GroupingsPage.xaml:** Adding AutomationID label to filters and headers * **GroupingsPageHeaderListItem.cs:** Adding `AutomationId` variable. * **GroupingsPageHeaderListGroup.cs:** Adding `AutomationId` variable. * **GroupingsPageListItem.cs:** Adding `AutomationId` variable. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:36:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#29669
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?