github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 12:58:36 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2517] [MERGED] [PM-2219] Dependency Updates #29621

New Issue
Closed
opened 2026-04-18 13:34:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:34:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2517
Author: @mpbw2
Created: 5/10/2023
Status: ✅ Merged
Merged: 5/11/2023
Merged by: @mpbw2

Base: master ← Head: lib-updates

📝 Commits (1)

📊 Changes

13 files changed (+34 additions, -35 deletions)

View changed files

📝 src/Android/Android.csproj (+8 -9)
📝 src/App/App.csproj (+4 -4)
📝 src/Core/Core.csproj (+4 -4)
📝 src/iOS.Autofill/iOS.Autofill.csproj (+1 -1)
📝 src/iOS.Extension/Info.plist (+1 -1)
📝 src/iOS.Extension/iOS.Extension.csproj (+1 -1)
📝 src/iOS.ShareExtension/Info.plist (+1 -1)
📝 src/iOS.ShareExtension/iOS.ShareExtension.csproj (+1 -1)
📝 src/iOS/Info.plist (+1 -1)
📝 src/iOS/iOS.csproj (+1 -1)
📝 test/Common/Common.csproj (+5 -5)
📝 test/Core.Test/Core.Test.csproj (+5 -5)
📝 test/Core.Test/Models/Request/SendRequestTests.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Dependency updates galore.

Note 1: Some Android libs (AndroidX.AppCompat, AndroidX.MediaRouter, and Google.Material.Android) could not be updated to their latest versions due to being compiled at a higher build target than the current public Xamarin.Forms (fixed in an upcoming XF release - I tested against 5.0.0.8491 and everything seemed happy).

Note 2: Updating MessagePack* breaks the Android build with the following error:

Xamarin.Android.Legacy.targets(317, 5): [XA2002] Can not resolve reference: `Microsoft.NET.StringTools`, referenced by `MessagePack`. Please add a NuGet package or assembly reference for `Microsoft.NET.StringTools`, or remove the reference to `MessagePack`.

I'm not sure of the correct path forward here so I'll need input from @fedemkr & @vvolkgang . Note that iOS continues to build fine with this update so /shrug

Note 3: Saving Google.Apis.AndroidPublisher.v3 updates for another day to prevent breaking the Github publishing automation (it's a big version jump so the likelihood of it bursting into flames is high)

Code changes

  • *.csproj: Dependency version bumps
  • info.plist: Change iOS minimum supported version to 11 to support MS AppCenter 5.x
  • SendRequestTests.cs: Declare param as long to support fixed strict input in xunit 2.4.2

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2517 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 5/10/2023 **Status:** ✅ Merged **Merged:** 5/11/2023 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `lib-updates` --- ### 📝 Commits (1) - [`c2629c1`](https://github.com/bitwarden/android/commit/c2629c1fd18f3edb257b7bcb17b801de85158a13) Dependency Updates ### 📊 Changes **13 files changed** (+34 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+8 -9) 📝 `src/App/App.csproj` (+4 -4) 📝 `src/Core/Core.csproj` (+4 -4) 📝 `src/iOS.Autofill/iOS.Autofill.csproj` (+1 -1) 📝 `src/iOS.Extension/Info.plist` (+1 -1) 📝 `src/iOS.Extension/iOS.Extension.csproj` (+1 -1) 📝 `src/iOS.ShareExtension/Info.plist` (+1 -1) 📝 `src/iOS.ShareExtension/iOS.ShareExtension.csproj` (+1 -1) 📝 `src/iOS/Info.plist` (+1 -1) 📝 `src/iOS/iOS.csproj` (+1 -1) 📝 `test/Common/Common.csproj` (+5 -5) 📝 `test/Core.Test/Core.Test.csproj` (+5 -5) 📝 `test/Core.Test/Models/Request/SendRequestTests.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Dependency updates galore. **_Note 1:_** Some Android libs (`AndroidX.AppCompat`, `AndroidX.MediaRouter`, and `Google.Material.Android`) could not be updated to their latest versions due to being compiled at a higher build target than the current public `Xamarin.Forms` (fixed in an upcoming XF release - I tested against `5.0.0.8491` and everything seemed happy). **_Note 2:_** Updating `MessagePack*` breaks the Android build with the following error: ``` Xamarin.Android.Legacy.targets(317, 5): [XA2002] Can not resolve reference: `Microsoft.NET.StringTools`, referenced by `MessagePack`. Please add a NuGet package or assembly reference for `Microsoft.NET.StringTools`, or remove the reference to `MessagePack`. ``` I'm not sure of the correct path forward here so I'll need input from @fedemkr & @vvolkgang . Note that iOS continues to build fine with this update so /shrug **_Note 3:_** Saving `Google.Apis.AndroidPublisher.v3` updates for another day to prevent breaking the Github publishing automation (it's a big version jump so the likelihood of it bursting into flames is high) ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * ***.csproj:** Dependency version bumps * **info.plist:** Change iOS minimum supported version to 11 to support MS AppCenter 5.x * **SendRequestTests.cs:** Declare param as long to support fixed strict input in `xunit 2.4.2` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:34:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#29621
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?