[PR #2510] [MERGED] [PM-1798] [BEEEP] Fix VoiceOver on buttons when adding new item on iOS extension #29617

Closed
opened 2026-04-18 13:34:24 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2510
Author: @fedemkr
Created: 5/5/2023
Status: ✅ Merged
Merged: 5/5/2023
Merged by: @fedemkr

Base: master ← Head: PM-1798-fix-voice-over-add-item-ios-extension


📝 Commits (1)

  • 0ee6652 PM-1798 Fix voice over on buttons when adding new item from iOS extension

📊 Changes

2 files changed (+6 additions, -0 deletions)

View changed files

📝 src/iOS.Core/Controllers/LoginAddViewController.cs (+2 -0)
📝 src/iOS.Core/Views/FormEntryTableViewCell.cs (+4 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

🐛 Fix VoiceOver on buttons when adding new item on iOS extension.

Code changes

  • LoginAddViewController: Added the accessibility label to the button so VoiceOver can read it.
  • FormEntryTableViewCell: Added the accessibility label and hint to the button so VoiceOver can read it.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2510 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 5/5/2023 **Status:** ✅ Merged **Merged:** 5/5/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `PM-1798-fix-voice-over-add-item-ios-extension` --- ### 📝 Commits (1) - [`0ee6652`](https://github.com/bitwarden/android/commit/0ee6652f68c5aea38a7dc657d58842fad2a3bac5) PM-1798 Fix voice over on buttons when adding new item from iOS extension ### 📊 Changes **2 files changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Core/Controllers/LoginAddViewController.cs` (+2 -0) 📝 `src/iOS.Core/Views/FormEntryTableViewCell.cs` (+4 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> 🐛 Fix VoiceOver on buttons when adding new item on iOS extension. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **LoginAddViewController:** Added the accessibility label to the button so VoiceOver can read it. * **FormEntryTableViewCell:** Added the accessibility label and hint to the button so VoiceOver can read it. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:34:24 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#29617