[PR #1541] [MERGED] Icon Updates #2952

Closed
opened 2025-11-26 23:26:21 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1541
Author: @Hinton
Created: 9/15/2021
Status: Merged
Merged: 1/21/2022
Merged by: @Hinton

Base: masterHead: feature/ui-icons


📝 Commits (10+)

📊 Changes

96 files changed (+373 additions, -258 deletions)

View changed files

📝 src/Android/Android.csproj (+3 -3)
src/Android/Assets/FontAwesome.ttf (+0 -0)
src/Android/Assets/bwi-font.ttf (+0 -0)
📝 src/Android/Resources/drawable/card.xml (+5 -5)
📝 src/Android/Resources/drawable/cog.xml (+5 -5)
src/Android/Resources/drawable/generate.xml (+9 -0)
📝 src/Android/Resources/drawable/id.xml (+5 -5)
📝 src/Android/Resources/drawable/info.xml (+7 -7)
📝 src/Android/Resources/drawable/lock.xml (+5 -5)
📝 src/Android/Resources/drawable/login.xml (+5 -5)
src/Android/Resources/drawable/paper_plane.xml (+0 -9)
📝 src/Android/Resources/drawable/pencil.xml (+5 -5)
📝 src/Android/Resources/drawable/plus.xml (+7 -7)
src/Android/Resources/drawable/refresh.xml (+0 -9)
📝 src/Android/Resources/drawable/search.xml (+7 -7)
src/Android/Resources/drawable/send.xml (+9 -0)
📝 src/Android/Resources/drawable/shield.xml (+5 -5)
📝 src/Android/Tiles/GeneratorTileService.cs (+1 -1)
📝 src/App/Controls/CipherViewCell/CipherViewCell.xaml (+6 -5)
📝 src/App/Controls/IconButton.cs (+4 -4)

...and 76 more files

📄 Description

Objective

Updates the Mobile Application with the new icons. This was made fairly difficult due to us the unicode representative of the icons throughout the whole application. To avoid this issue in the future, and also to provide clarity in which icons are used where, I created a BitwardenIcons class which holds the unicode mappings.

https://app.asana.com/0/1200804338582616/1200487492949147


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1541 **Author:** [@Hinton](https://github.com/Hinton) **Created:** 9/15/2021 **Status:** ✅ Merged **Merged:** 1/21/2022 **Merged by:** [@Hinton](https://github.com/Hinton) **Base:** `master` ← **Head:** `feature/ui-icons` --- ### 📝 Commits (10+) - [`0c513a1`](https://github.com/bitwarden/android/commit/0c513a11809bf6a77cf5e3f5c80e7156c0f0f0e4) Implement new icons - [`207aa22`](https://github.com/bitwarden/android/commit/207aa22c91c8aa34db68876b4cf09a12d463934d) Add iOS icons - [`00ade92`](https://github.com/bitwarden/android/commit/00ade9249573c3c955aa6fe2f617e48f3cdc3bda) Renmove FontAwesome.ttf - [`564a6f8`](https://github.com/bitwarden/android/commit/564a6f8875ae5287639ecf800a876190468a2ad4) Switch generator icon - [`6407293`](https://github.com/bitwarden/android/commit/64072936231191ffcfda18484a3538abfd8e777d) Cleanup - [`43183f1`](https://github.com/bitwarden/android/commit/43183f133c6a27e136ff01bc1173a4fea2a17fe8) Restore LaunchScreen.storyboard - [`dae610f`](https://github.com/bitwarden/android/commit/dae610f1b31bcbc240b18944a9468c75e74b1026) Use C# character literals for unicode icons - [`1115d4e`](https://github.com/bitwarden/android/commit/1115d4e119ba635875e4044d47c4f1da173b4244) Rename FaLabel and FaButton to IconLabel and IconButton - [`996090a`](https://github.com/bitwarden/android/commit/996090ae2a8f45403cf55a53eca5b845e123599c) Update icons - [`592727f`](https://github.com/bitwarden/android/commit/592727f1ca52cdff2920964cc8459f66cda3b460) Update font ### 📊 Changes **96 files changed** (+373 additions, -258 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+3 -3) ➖ `src/Android/Assets/FontAwesome.ttf` (+0 -0) ➕ `src/Android/Assets/bwi-font.ttf` (+0 -0) 📝 `src/Android/Resources/drawable/card.xml` (+5 -5) 📝 `src/Android/Resources/drawable/cog.xml` (+5 -5) ➕ `src/Android/Resources/drawable/generate.xml` (+9 -0) 📝 `src/Android/Resources/drawable/id.xml` (+5 -5) 📝 `src/Android/Resources/drawable/info.xml` (+7 -7) 📝 `src/Android/Resources/drawable/lock.xml` (+5 -5) 📝 `src/Android/Resources/drawable/login.xml` (+5 -5) ➖ `src/Android/Resources/drawable/paper_plane.xml` (+0 -9) 📝 `src/Android/Resources/drawable/pencil.xml` (+5 -5) 📝 `src/Android/Resources/drawable/plus.xml` (+7 -7) ➖ `src/Android/Resources/drawable/refresh.xml` (+0 -9) 📝 `src/Android/Resources/drawable/search.xml` (+7 -7) ➕ `src/Android/Resources/drawable/send.xml` (+9 -0) 📝 `src/Android/Resources/drawable/shield.xml` (+5 -5) 📝 `src/Android/Tiles/GeneratorTileService.cs` (+1 -1) 📝 `src/App/Controls/CipherViewCell/CipherViewCell.xaml` (+6 -5) 📝 `src/App/Controls/IconButton.cs` (+4 -4) _...and 76 more files_ </details> ### 📄 Description ## Objective Updates the Mobile Application with the new icons. This was made fairly difficult due to us the unicode representative of the icons throughout the whole application. To avoid this issue in the future, and also to provide clarity in which icons are used where, I created a `BitwardenIcons` class which holds the unicode mappings. https://app.asana.com/0/1200804338582616/1200487492949147 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:26:21 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2952