github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1534] [MERGED] friendly message for webauthn errors #2948

New Issue
Closed
opened 2025-11-26 23:26:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:26:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1534
Author: @mpbw2
Created: 9/8/2021
Status: ✅ Merged
Merged: 9/9/2021
Merged by: @mpbw2

Base: master ← Head: feature-fido2-friendlyerror

📝 Commits (3)

  • 1a3b7fd friendly error message for webauthn error flow
  • fbe1e83 combine original plus friendly message
  • 45aa5cc remove redundant phrasing

📊 Changes

3 files changed (+7 additions, -6 deletions)

View changed files

📝 src/App/Pages/Accounts/TwoFactorPageViewModel.cs (+3 -2)
📝 src/App/Resources/AppResources.Designer.cs (+2 -2)
📝 src/App/Resources/AppResources.resx (+2 -2)

📄 Description

Edited with final screenshots

Prepend WebAuthn error messages with a friendly/helpful message to hopefully cut down on support requests.

Key points conveyed:

  1. User's browser must support WebAuthn, and
  2. It has to be set as the default browser (per WebAuthenticator requirements)

New message:

device-2021-09-08-183325

Old message:

before2

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1534 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 9/8/2021 **Status:** ✅ Merged **Merged:** 9/9/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `feature-fido2-friendlyerror` --- ### 📝 Commits (3) - [`1a3b7fd`](https://github.com/bitwarden/android/commit/1a3b7fd4f1582005bd1068e86f5cf704b1277d41) friendly error message for webauthn error flow - [`fbe1e83`](https://github.com/bitwarden/android/commit/fbe1e83bc61b2c99e2a86a130f2cc024238ee664) combine original plus friendly message - [`45aa5cc`](https://github.com/bitwarden/android/commit/45aa5ccf1f941c7c026a764900ad1ed66420168a) remove redundant phrasing ### 📊 Changes **3 files changed** (+7 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/TwoFactorPageViewModel.cs` (+3 -2) 📝 `src/App/Resources/AppResources.Designer.cs` (+2 -2) 📝 `src/App/Resources/AppResources.resx` (+2 -2) </details> ### 📄 Description _Edited with final screenshots_ Prepend WebAuthn error messages with a friendly/helpful message to hopefully cut down on support requests. Key points conveyed: 1. User's browser must support WebAuthn, and 2. It has to be set as the default browser (per WebAuthenticator requirements) New message: ![device-2021-09-08-183325](https://user-images.githubusercontent.com/59324545/132594579-c8420013-cacf-41d2-a761-13acbaf85b9e.png) Old message: ![before2](https://user-images.githubusercontent.com/59324545/132591150-34ae7796-1c35-49ec-ae42-8797c90c3226.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:26:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2948
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?