github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-09 16:21:19 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #1976] [MERGED] [EC-303] Add warning when vault timeout is set to "Never" #29274

New Issue
Closed
opened 2026-04-18 13:17:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:17:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1976
Author: @r-tome
Created: 7/6/2022
Status: ✅ Merged
Merged: 7/7/2022
Merged by: @r-tome

Base: master ← Head: EC-303-add-warning-when-vault-timeout-is-set-to-never-mobile

📝 Commits (5)

  • 9f1f8b0 Added to AppResources.resx the message warning the user about setting the lockout option to "Never"
  • e0c8339 Added the condition to check the newly selected option on the vault timeout settings
  • 66feca9 Changed the wording on the warning as to reflect the mobile version
  • 04c486e Changed the vault timeout modal to have the ability to cancel
  • 67f87d7 Simplified the reversion of value if the user cancels the change

📊 Changes

3 files changed (+22 additions, -0 deletions)

View changed files

📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+11 -0)
📝 src/App/Resources/AppResources.Designer.cs (+8 -0)
📝 src/App/Resources/AppResources.resx (+3 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Added a warning when the user selects vault timeout value "Never". Similar to what already happens on the browser client.

Code changes

  • src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs Added the condition to check the newly selected option on the vault timeout settings
  • src/App/Resources/AppResources.Designer.cs Added the static string NeverLockWarning to get the text from AppResources.resx
  • src/App/Resources/AppResources.resx Added the message warning the user about setting the lockout option to "Never"

Screenshots

image
image

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1976 **Author:** [@r-tome](https://github.com/r-tome) **Created:** 7/6/2022 **Status:** ✅ Merged **Merged:** 7/7/2022 **Merged by:** [@r-tome](https://github.com/r-tome) **Base:** `master` ← **Head:** `EC-303-add-warning-when-vault-timeout-is-set-to-never-mobile` --- ### 📝 Commits (5) - [`9f1f8b0`](https://github.com/bitwarden/android/commit/9f1f8b02f9e4359599015404cd7923962788efa9) Added to AppResources.resx the message warning the user about setting the lockout option to "Never" - [`e0c8339`](https://github.com/bitwarden/android/commit/e0c833994baa9c2af539e6c28778b7a873878a9d) Added the condition to check the newly selected option on the vault timeout settings - [`66feca9`](https://github.com/bitwarden/android/commit/66feca9b58e19a125de4d41b02b0616a15e56a6d) Changed the wording on the warning as to reflect the mobile version - [`04c486e`](https://github.com/bitwarden/android/commit/04c486e7674a74654eca85110cb322d5021df7de) Changed the vault timeout modal to have the ability to cancel - [`67f87d7`](https://github.com/bitwarden/android/commit/67f87d72630c7161b23da2223e2f42befb3c1599) Simplified the reversion of value if the user cancels the change ### 📊 Changes **3 files changed** (+22 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+11 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+8 -0) 📝 `src/App/Resources/AppResources.resx` (+3 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective Added a warning when the user selects vault timeout value "Never". Similar to what already happens on the browser client. ## Code changes * **src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs** Added the condition to check the newly selected option on the vault timeout settings * **src/App/Resources/AppResources.Designer.cs** Added the static string NeverLockWarning to get the text from AppResources.resx * **src/App/Resources/AppResources.resx** Added the message warning the user about setting the lockout option to "Never" ## Screenshots ![image](https://user-images.githubusercontent.com/108268980/177799294-e4f57c13-7d6d-40d3-b2a8-3bfb1256f331.png) <img width="374" alt="image" src="https://user-images.githubusercontent.com/108268980/177800083-7a6123c7-3d0f-479d-9d51-ad797251f0a0.png"> ## Before you submit - [X] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:17:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#29274
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?