github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1470] [MERGED] Move remaining primary buttons in login flow #2911

New Issue
Closed
opened 2025-11-26 23:25:49 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:49 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1470
Author: @eliykat
Created: 7/21/2021
Status: ✅ Merged
Merged: 7/21/2021
Merged by: @eliykat

Base: master ← Head: fix-2fa-page

📝 Commits (4)

  • a41a614 Fix show/hide logic on Continue button
  • 02e3eda Fix bug in 2FA method selection modal
  • fd803fa Move Log In button in SSO flow
  • 4c50b22 Fix linting

📊 Changes

2 files changed (+11 additions, -3 deletions)

View changed files

📝 src/App/Pages/Accounts/LoginSsoPage.xaml (+4 -1)
📝 src/App/Pages/Accounts/TwoFactorPageViewModel.cs (+7 -2)

📄 Description

Objective

Some work to finish off #1427.

On the 2FA page:

  • Fix QA feedback that the "Continue" button was not properly showing/hiding based on the selected 2FA method. This was because we weren't using setProperty in the ShowContinue getter, so the bindings weren't being updated.
  • Fix an unrelated bug where clicking off the "Use another method" modal (without selecting an option or clicking cancel) would act as if the user had selected an unsupported 2FA method.

On the SSO page:

  • Move Log In button to be consistent with the other login pages.

Screen Shot 2021-07-21 at 9 50 49 pm

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1470 **Author:** [@eliykat](https://github.com/eliykat) **Created:** 7/21/2021 **Status:** ✅ Merged **Merged:** 7/21/2021 **Merged by:** [@eliykat](https://github.com/eliykat) **Base:** `master` ← **Head:** `fix-2fa-page` --- ### 📝 Commits (4) - [`a41a614`](https://github.com/bitwarden/android/commit/a41a614bc3fda7753d8e0c055fd47f64f378a079) Fix show/hide logic on Continue button - [`02e3eda`](https://github.com/bitwarden/android/commit/02e3eda80708d4d5fd28ed748400739e90d46426) Fix bug in 2FA method selection modal - [`fd803fa`](https://github.com/bitwarden/android/commit/fd803fa0e86f146b53054d6d9c9a48e12af86f17) Move Log In button in SSO flow - [`4c50b22`](https://github.com/bitwarden/android/commit/4c50b220851c7e8ff974544c9666e6865095373f) Fix linting ### 📊 Changes **2 files changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LoginSsoPage.xaml` (+4 -1) 📝 `src/App/Pages/Accounts/TwoFactorPageViewModel.cs` (+7 -2) </details> ### 📄 Description ## Objective Some work to finish off #1427. On the 2FA page: * Fix QA feedback that the "Continue" button was not properly showing/hiding based on the selected 2FA method. This was because we weren't using `setProperty` in the `ShowContinue` getter, so the bindings weren't being updated. * Fix an unrelated bug where clicking off the "Use another method" modal (without selecting an option or clicking cancel) would act as if the user had selected an unsupported 2FA method. On the SSO page: * Move Log In button to be consistent with the other login pages. ![Screen Shot 2021-07-21 at 9 50 49 pm](https://user-images.githubusercontent.com/31796059/126484232-9d88e6ad-bb0c-4b69-a947-f4fc3e90e6eb.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:49 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2911
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?