[PR #1454] [MERGED] Workaround for off-screen draw bug in XF4.5+ part 2 (Send) #2901

Closed
opened 2025-11-26 23:25:41 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1454
Author: @mpbw2
Created: 7/9/2021
Status: Merged
Merged: 7/9/2021
Merged by: @mpbw2

Base: masterHead: workaround-sendoptions


📝 Commits (1)

  • d56d2d5 workaround for off-screen draw bug in XF4.5+ part 2

📊 Changes

1 file changed (+4 additions, -5 deletions)

View changed files

📝 src/App/Pages/Send/SendAddEditPage.xaml (+4 -5)

📄 Description

The same issue we had to work around in #1447 also occurred in the collapsible Options panel when adding/editing a Send. Thankfully this one was easier to work around simply by locking the panel open so it's drawn initially and never needs to be re-drawn. (This should also be reverted once the Forms bug is fixed)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1454 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 7/9/2021 **Status:** ✅ Merged **Merged:** 7/9/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `workaround-sendoptions` --- ### 📝 Commits (1) - [`d56d2d5`](https://github.com/bitwarden/android/commit/d56d2d57a07f79e7a6ef39c9e35d87e9743fba15) workaround for off-screen draw bug in XF4.5+ part 2 ### 📊 Changes **1 file changed** (+4 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Send/SendAddEditPage.xaml` (+4 -5) </details> ### 📄 Description The same issue we had to work around in #1447 also occurred in the collapsible `Options` panel when adding/editing a Send. Thankfully this one was easier to work around simply by locking the panel open so it's drawn initially and never needs to be re-drawn. (This should also be reverted once the Forms bug is fixed) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:41 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2901