github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-21 03:21:29 -05:00
Code Issues 1.5k Packages Projects Releases 125 Wiki Activity

[PR #1570] [MERGED] Fix crash from SelectableLabelRenderer #28979

New Issue
Closed
opened 2026-04-18 13:01:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:01:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1570
Author: @jlf0dev
Created: 10/8/2021
Status: ✅ Merged
Merged: 10/8/2021
Merged by: @jlf0dev

Base: master ← Head: bug/note-copy-text

📝 Commits (4)

  • 840f132 Add SelectableLabel Custom Renderer to allow copy of note text
  • 2750507 Remove editor changes from text custom field
  • 8a4b719 Fix crash when Element is null
  • 29d77a9 Merge branch 'master' into bug/note-copy-text

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 src/iOS.Core/Renderers/SelectableLabelRenderer.cs (+5 -0)

📄 Description

The custom renderer for iOS was crashing when the element was discarded as there was no null check.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1570 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 10/8/2021 **Status:** ✅ Merged **Merged:** 10/8/2021 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `bug/note-copy-text` --- ### 📝 Commits (4) - [`840f132`](https://github.com/bitwarden/android/commit/840f1322dbd29f76a9b497b593e43549597814a7) Add SelectableLabel Custom Renderer to allow copy of note text - [`2750507`](https://github.com/bitwarden/android/commit/2750507fb786df60ff30c513a8b784c4168e6ad9) Remove editor changes from text custom field - [`8a4b719`](https://github.com/bitwarden/android/commit/8a4b719505c30532b12c857926d4097045f042f1) Fix crash when Element is null - [`29d77a9`](https://github.com/bitwarden/android/commit/29d77a932a090c16bea5ed302a42621f4ed6fa9d) Merge branch 'master' into bug/note-copy-text ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Core/Renderers/SelectableLabelRenderer.cs` (+5 -0) </details> ### 📄 Description The custom renderer for iOS was crashing when the element was discarded as there was no null check. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:01:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#28979
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?