github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1448] [MERGED] Fix for export password handling #2897

New Issue
Closed
opened 2025-11-26 23:25:38 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:38 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1448
Author: @mpbw2
Created: 6/30/2021
Status: ✅ Merged
Merged: 6/30/2021
Merged by: @mpbw2

Base: master ← Head: bugfix-export

📝 Commits (1)

  • 9c6f380 fix for export password handling

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 src/App/Pages/Settings/ExportVaultPageViewModel.cs (+2 -3)

📄 Description

Fix for password handling in vault export:

  • Don't clear MasterPassword property until after sending the backing var to CompareAndUpdateKeyHashAsync
  • Negate passwordValid for proper error flow

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1448 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 6/30/2021 **Status:** ✅ Merged **Merged:** 6/30/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-export` --- ### 📝 Commits (1) - [`9c6f380`](https://github.com/bitwarden/android/commit/9c6f3802337a091582baeb04eacfd2bba2a65138) fix for export password handling ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/ExportVaultPageViewModel.cs` (+2 -3) </details> ### 📄 Description Fix for password handling in vault export: - Don't clear `MasterPassword` property until after sending the backing var to `CompareAndUpdateKeyHashAsync` - Negate `passwordValid` for proper error flow --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:38 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2897
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?