github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1433] [MERGED] Redefine cipher "share" to "move to organization" #2886

New Issue
Closed
opened 2025-11-26 23:25:30 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:30 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1433
Author: @MGibson1
Created: 6/17/2021
Status: ✅ Merged
Merged: 6/18/2021
Merged by: @MGibson1

Base: master ← Head: change-share-term

📝 Commits (1)

  • 37d2ea2 Redefine cipher "share" to "move to organization"

📊 Changes

11 files changed (+69 additions, -39 deletions)

View changed files

📝 src/App/Controls/CipherViewCell/CipherViewCell.xaml (+1 -1)
📝 src/App/Pages/Settings/SettingsPage/SettingsPage.xaml.cs (+1 -1)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+3 -3)
📝 src/App/Pages/Vault/AddEditPage.xaml (+1 -1)
📝 src/App/Pages/Vault/AddEditPage.xaml.cs (+2 -2)
📝 src/App/Pages/Vault/SharePage.xaml (+2 -2)
📝 src/App/Pages/Vault/SharePageViewModel.cs (+4 -2)
📝 src/App/Pages/Vault/ViewPage.xaml (+1 -1)
📝 src/App/Pages/Vault/ViewPage.xaml.cs (+2 -2)
📝 src/App/Resources/AppResources.Designer.cs (+36 -18)
📝 src/App/Resources/AppResources.resx (+16 -6)

📄 Description

Overview

The term "Share" is confusing to users because it implies maintaining ownership and control of a cipher while allowing others to access it as well. It also implies the ability to revoke access or to stop sharing -- neither of these things is true.

In addition to the share term being misleading, the fa-share-alt icon implies a forking of the cipher item rather than transferring ownership.

When a cipher is "shared" it is irrevocably taken over by an organization. This occurs for good cryptographic and security reasons. The better solution to this is to revise the communication around "sharing." To that end, this work changes the term "share" to "move to organization" and the icon is changed to fa-cube, which is used to indicate a collection. The act of moving an item to an organization is denoted by fa-arrow-circle-o-right rather than fa-share-alt.

Screen shots

Item View Options

image image

Item Edit Options

image image

Move To Organization View

image image

Move To Organization Toast

image image

Item hint part of Organization

image image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1433 **Author:** [@MGibson1](https://github.com/MGibson1) **Created:** 6/17/2021 **Status:** ✅ Merged **Merged:** 6/18/2021 **Merged by:** [@MGibson1](https://github.com/MGibson1) **Base:** `master` ← **Head:** `change-share-term` --- ### 📝 Commits (1) - [`37d2ea2`](https://github.com/bitwarden/android/commit/37d2ea2ba912988d5180c6ccac44f8b1a48f4160) Redefine cipher "share" to "move to organization" ### 📊 Changes **11 files changed** (+69 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/CipherViewCell/CipherViewCell.xaml` (+1 -1) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPage.xaml.cs` (+1 -1) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+3 -3) 📝 `src/App/Pages/Vault/AddEditPage.xaml` (+1 -1) 📝 `src/App/Pages/Vault/AddEditPage.xaml.cs` (+2 -2) 📝 `src/App/Pages/Vault/SharePage.xaml` (+2 -2) 📝 `src/App/Pages/Vault/SharePageViewModel.cs` (+4 -2) 📝 `src/App/Pages/Vault/ViewPage.xaml` (+1 -1) 📝 `src/App/Pages/Vault/ViewPage.xaml.cs` (+2 -2) 📝 `src/App/Resources/AppResources.Designer.cs` (+36 -18) 📝 `src/App/Resources/AppResources.resx` (+16 -6) </details> ### 📄 Description # Overview The term "Share" is confusing to users because it implies maintaining ownership and control of a cipher while allowing others to access it as well. It also implies the ability to revoke access or to stop sharing -- neither of these things is true. In addition to the share term being misleading, the [`fa-share-alt`](https://fontawesome.com/v4.7/icon/share-alt) icon implies a forking of the cipher item rather than transferring ownership. When a cipher is "shared" it is irrevocably taken over by an organization. This occurs for good cryptographic and security reasons. The better solution to this is to revise the communication around "sharing." To that end, this work changes the term "share" to "move to organization" and the icon is changed to [`fa-cube`](https://fontawesome.com/v4.7/icon/cube), which is used to indicate a collection. The act of moving an item to an organization is denoted by [`fa-arrow-circle-o-right`](https://fontawesome.com/v4.7/icon/arrow-circle-o-right) rather than `fa-share-alt`. # Screen shots #### Item View Options <img width="506" alt="image" src="https://user-images.githubusercontent.com/18214891/122468655-99067480-cf81-11eb-9b38-503d23972f8a.png"> <img width="423" alt="image" src="https://user-images.githubusercontent.com/18214891/122470530-c6542200-cf83-11eb-9f2e-27627e4cdca2.png"> #### Item Edit Options <img width="506" alt="image" src="https://user-images.githubusercontent.com/18214891/122468682-a3287300-cf81-11eb-8063-90b12d0ac320.png"> <img width="423" alt="image" src="https://user-images.githubusercontent.com/18214891/122470557-cd7b3000-cf83-11eb-9f5b-62f52fbe64a3.png"> #### Move To Organization View <img width="506" alt="image" src="https://user-images.githubusercontent.com/18214891/122468727-af143500-cf81-11eb-8c29-bbf1593f63e0.png"> <img width="423" alt="image" src="https://user-images.githubusercontent.com/18214891/122470585-d7049800-cf83-11eb-8a88-6802f663d7fa.png"> #### Move To Organization Toast <img width="506" alt="image" src="https://user-images.githubusercontent.com/18214891/122469750-ea633380-cf82-11eb-8eb6-c8dcc5bb5bb9.png"> <img width="423" alt="image" src="https://user-images.githubusercontent.com/18214891/122470609-e1269680-cf83-11eb-91aa-0f462a4efb21.png"> #### Item hint part of Organization <img width="326" alt="image" src="https://user-images.githubusercontent.com/18214891/122469849-049d1180-cf83-11eb-8a36-1ff743708cdc.png"> <img width="326" alt="image" src="https://user-images.githubusercontent.com/18214891/122470435-acb2da80-cf83-11eb-89b7-a92de7aedede.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:30 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2886
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?