github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 13:14:35 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1427] [MERGED] 2FA screen: move continue to a button #2883

New Issue
Closed
opened 2025-11-26 23:25:28 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:28 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1427
Author: @sangxxh
Created: 6/13/2021
Status: ✅ Merged
Merged: 7/20/2021
Merged by: @eliykat

Base: master ← Head: issue/1419-2fa-continue-button-placement

📝 Commits (8)

  • f17293b Move continue to a button
  • 3bde36c Resolve pr comments
  • c2f2d16 Merge branch 'master' into issue/1419-2fa-continue-button-placement
  • e2ee73c Move use another two step method button
  • 5bd7f08 Resolve code suggestions
  • 5603221 Merge branch 'master' into issue/1419-2fa-continue-button-placement
  • 9389b2f Resolve for iPhone
  • e3c68f6 Apply suggestions from code review

📊 Changes

3 files changed (+54 additions, -29 deletions)

View changed files

📝 src/App/Pages/Accounts/TwoFactorPage.xaml (+17 -6)
📝 src/App/Pages/Accounts/TwoFactorPage.xaml.cs (+27 -15)
📝 src/App/Pages/Accounts/TwoFactorPageViewModel.cs (+10 -8)

📄 Description

Close #1419

Changes

  • Move "Continue" to a button at the bottom
  • Button is disabled until Verification Code field is not empty

Demo

https://user-images.githubusercontent.com/11912225/121795363-511ae100-cc53-11eb-85d2-1a1c228f0a0b.mp4

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1427 **Author:** [@sangxxh](https://github.com/sangxxh) **Created:** 6/13/2021 **Status:** ✅ Merged **Merged:** 7/20/2021 **Merged by:** [@eliykat](https://github.com/eliykat) **Base:** `master` ← **Head:** `issue/1419-2fa-continue-button-placement` --- ### 📝 Commits (8) - [`f17293b`](https://github.com/bitwarden/android/commit/f17293b68c7fb1b37570a6aeb5745bd938a805d4) Move continue to a button - [`3bde36c`](https://github.com/bitwarden/android/commit/3bde36c69b7a1304639f91b95816d7efcc42ec69) Resolve pr comments - [`c2f2d16`](https://github.com/bitwarden/android/commit/c2f2d162be8cc1bc946dd763f2f4d6e6a7031873) Merge branch 'master' into issue/1419-2fa-continue-button-placement - [`e2ee73c`](https://github.com/bitwarden/android/commit/e2ee73c980621d295da1f30e762c86aff46c3299) Move use another two step method button - [`5bd7f08`](https://github.com/bitwarden/android/commit/5bd7f08bea260060044669cc4200c3d075342ed3) Resolve code suggestions - [`5603221`](https://github.com/bitwarden/android/commit/56032215203e4dc964adb690b401a828569b731a) Merge branch 'master' into issue/1419-2fa-continue-button-placement - [`9389b2f`](https://github.com/bitwarden/android/commit/9389b2f32ef6e959bae43fba6bd91aad093e1cc9) Resolve for iPhone - [`e3c68f6`](https://github.com/bitwarden/android/commit/e3c68f68017aab88094b86120b82f8efa56f0780) Apply suggestions from code review ### 📊 Changes **3 files changed** (+54 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/TwoFactorPage.xaml` (+17 -6) 📝 `src/App/Pages/Accounts/TwoFactorPage.xaml.cs` (+27 -15) 📝 `src/App/Pages/Accounts/TwoFactorPageViewModel.cs` (+10 -8) </details> ### 📄 Description Close #1419 ### Changes - Move *"Continue"* to a button at the bottom - Button is disabled until *Verification Code* field is not empty ### Demo https://user-images.githubusercontent.com/11912225/121795363-511ae100-cc53-11eb-85d2-1a1c228f0a0b.mp4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:28 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2883
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?